From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27616 invoked by alias); 21 Apr 2010 20:24:03 -0000 Received: (qmail 27579 invoked by uid 22791); 21 Apr 2010 20:24:00 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=BAYES_00,TW_XF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Apr 2010 20:23:55 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o3LKNnwd027124; Wed, 21 Apr 2010 22:23:49 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o3LKNlgT022423; Wed, 21 Apr 2010 22:23:47 +0200 (CEST) Date: Wed, 21 Apr 2010 20:24:00 -0000 Message-Id: <201004212023.o3LKNlgT022423@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: hjl.tools@gmail.com CC: gdb-patches@sourceware.org In-reply-to: <20100421201820.GA32756@intel.com> (hongjiu.lu@intel.com) Subject: Re: PATCH: Fix 32bit coredump read on Linux/AVX References: <20100420032234.GA10544@intel.com> <20100420184339.GA18641@intel.com> <20100421201820.GA32756@intel.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00701.txt.bz2 > Date: Wed, 21 Apr 2010 13:18:20 -0700 > From: "H.J. Lu" > > On Tue, Apr 20, 2010 at 11:43:39AM -0700, H.J. Lu wrote: > > On Mon, Apr 19, 2010 at 08:22:34PM -0700, H.J. Lu wrote: > > > Hi, > > > > > > This patch: > > > > > > http://sourceware.org/ml/gdb-patches/2010-04/msg00276.html > > > > > > breaks 32bit coredump read on Linux/AVX since we only dump .reg and > > > .reg-xstate sections on AVX. But i386_linux_core_read_description > > > checks .reg2 and .reg-xfp sections first. Since there are no > > > .reg2 and .reg-xfp sections, NULL is returned and SSE target is used. > > > This patch changes the section check order to .reg-xstate, .reg-xfp, > > > .reg2. OK to install? > > > > > > Thanks. > > > > > > > .reg2 section has x87 regiters on i386 and SSE registers on amd64. > > Here is the updated patch to properly handle it. OK to install? > > > > Thanks. > > > > > > H.J. > > -- > > 2010-04-20 H.J. Lu > > > > PR corefiles/11523 > > * amd64-linux-tdep.c (amd64_linux_core_read_description): Check > > XCR0 first. > > > > * i386-linux-tdep.c (i386_linux_core_read_xcr0): Return 0 if > > there is no .reg-xstate section. > > (i386_linux_core_read_description): Check XCR0 first. > > > > This is the version I am checking in. Looks good, thanks! > 2010-04-21 H.J. Lu > > PR corefiles/11523 > * amd64-linux-tdep.c (amd64_linux_core_read_description): Check > XCR0 first. > > * i386-linux-tdep.c (i386_linux_core_read_xcr0): Return 0 if > there is no .reg-xstate section. > (i386_linux_core_read_description): Check XCR0 first.