From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17520 invoked by alias); 20 Apr 2010 03:22:42 -0000 Received: (qmail 17510 invoked by uid 22791); 20 Apr 2010 03:22:40 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM,TW_XF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mga05.intel.com (HELO fmsmga101.fm.intel.com) (192.55.52.89) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Apr 2010 03:22:36 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 19 Apr 2010 20:21:21 -0700 X-ExtLoop1: 1 Received: from gnu-6.sc.intel.com ([10.3.194.107]) by fmsmga001.fm.intel.com with ESMTP; 19 Apr 2010 20:22:28 -0700 Received: by gnu-6.sc.intel.com (Postfix, from userid 500) id 0F93B812386; Mon, 19 Apr 2010 20:22:35 -0700 (PDT) Date: Tue, 20 Apr 2010 03:22:00 -0000 From: "H.J. Lu" To: GDB Subject: PATCH: Fix 32bit coredump read on Linux/AVX Message-ID: <20100420032234.GA10544@intel.com> Reply-To: "H.J. Lu" MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-08-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00598.txt.bz2 Hi, This patch: http://sourceware.org/ml/gdb-patches/2010-04/msg00276.html breaks 32bit coredump read on Linux/AVX since we only dump .reg and .reg-xstate sections on AVX. But i386_linux_core_read_description checks .reg2 and .reg-xfp sections first. Since there are no .reg2 and .reg-xfp sections, NULL is returned and SSE target is used. This patch changes the section check order to .reg-xstate, .reg-xfp, .reg2. OK to install? Thanks. H.J. --- 2010-04-19 H.J. Lu * amd64-linux-tdep.c (amd64_linux_core_read_description): Always use xcr0 from i386_linux_core_read_xcr0. * i386-linux-tdep.c (i386_linux_core_read_xcr0): Check .reg-xfp and .reg2 sections for SSE and MMX. (i386_linux_core_read_description): Always use xcr0 from i386_linux_core_read_xcr0. diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c index f249d5d..e66c08e 100644 --- a/gdb/amd64-linux-tdep.c +++ b/gdb/amd64-linux-tdep.c @@ -1269,14 +1269,9 @@ amd64_linux_core_read_description (struct gdbarch *gdbarch, struct target_ops *target, bfd *abfd) { - asection *section = bfd_get_section_by_name (abfd, ".reg2"); - uint64_t xcr0; - - if (section == NULL) - return NULL; - /* Linux/x86-64. */ - xcr0 = i386_linux_core_read_xcr0 (gdbarch, target, abfd); + uint64_t xcr0 = i386_linux_core_read_xcr0 (gdbarch, target, abfd); + gdb_assert (xcr0 != 0); if ((xcr0 & I386_XSTATE_AVX_MASK) == I386_XSTATE_AVX_MASK) return tdesc_amd64_avx_linux; else diff --git a/gdb/i386-linux-tdep.c b/gdb/i386-linux-tdep.c index 5952153..750e039 100644 --- a/gdb/i386-linux-tdep.c +++ b/gdb/i386-linux-tdep.c @@ -610,8 +610,12 @@ i386_linux_core_read_xcr0 (struct gdbarch *gdbarch, xcr0 = bfd_get_64 (abfd, contents); } } - else + else if (bfd_get_section_by_name (abfd, ".reg-xfp") != NULL) xcr0 = I386_XSTATE_SSE_MASK; + else if (bfd_get_section_by_name (abfd, ".reg2") != NULL) + xcr0 = I386_XSTATE_X87_MASK; + else + xcr0 = 0; return xcr0; } @@ -623,22 +627,20 @@ i386_linux_core_read_description (struct gdbarch *gdbarch, struct target_ops *target, bfd *abfd) { - asection *section = bfd_get_section_by_name (abfd, ".reg2"); - uint64_t xcr0; - - if (section == NULL) - return NULL; - - section = bfd_get_section_by_name (abfd, ".reg-xfp"); - if (section == NULL) - return tdesc_i386_mmx_linux; + uint64_t xcr0 = i386_linux_core_read_xcr0 (gdbarch, target, abfd); /* Linux/i386. */ - xcr0 = i386_linux_core_read_xcr0 (gdbarch, target, abfd); - if ((xcr0 & I386_XSTATE_AVX_MASK) == I386_XSTATE_AVX_MASK) - return tdesc_i386_avx_linux; - else - return tdesc_i386_linux; + switch ((xcr0 & I386_XSTATE_AVX_MASK)) + { + case I386_XSTATE_AVX_MASK: + return tdesc_i386_avx_linux; + case I386_XSTATE_SSE_MASK: + return tdesc_i386_linux; + case I386_XSTATE_X87_MASK: + return tdesc_i386_mmx_linux; + default: + return NULL; + } } static void