From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28491 invoked by alias); 17 Apr 2010 08:28:04 -0000 Received: (qmail 28482 invoked by uid 22791); 17 Apr 2010 08:28:03 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Apr 2010 08:27:59 +0000 Received: (qmail 7274 invoked from network); 17 Apr 2010 08:27:57 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 17 Apr 2010 08:27:57 -0000 From: Pedro Alves To: "Pierre Muller" Subject: Re: [RFA] Use winsock2 for mingw gdbserver Date: Sat, 17 Apr 2010 08:28:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <000d01cadd79$efa9e2b0$cefda810$@muller@ics-cnrs.unistra.fr> <201004161815.36864.pedro@codesourcery.com> <001c01caddf0$63952a10$2abf7e30$@muller@ics-cnrs.unistra.fr> In-Reply-To: <001c01caddf0$63952a10$2abf7e30$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <201004170927.53523.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00526.txt.bz2 On Saturday 17 April 2010 06:39:45, Pierre Muller wrote: >=20 > Here you are: > is this OK? > Once again, it=92s the formatting of the > ChangeLog that seems the most uncertain to me... It's fine, although "Include winsock2.h instead of winsock.h" would be more straight to the point... (doesn't need to answer the question: "and what is the winsock2 header in the first place? ws2.h? other?") When in doubt, start by looking at previous entries. There are several `* file.c (foo): Include bar.h.', but none `* file.c (foo): Include bar hea= der.' > 2010-04-17 Pierre Muller >=20 > * configure.ac: Use `ws2_32' library for srv_mingw. > * configure: Regenerate. > * gdbreplay.c: Use winsock2 header instead of winsock for mingw. > * remote-utils.c: Likewise. This is okay. >=20 > Index: configure > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/gdbserver/configure,v > retrieving revision 1.47 > diff -u -p -r1.47 configure > --- configure 16 Apr 2010 16:22:15 -0000 1.47 > +++ configure 17 Apr 2010 05:25:59 -0000 > @@ -4056,7 +4056,7 @@ esac > if test "${srv_mingwce}" =3D "yes"; then > LIBS=3D"$LIBS -lws2" > elif test "${srv_mingw}" =3D "yes"; then > - LIBS=3D"$LIBS -lwsock32" > + LIBS=3D"$LIBS -lws2_32" > elif test "${srv_qnx}" =3D "yes"; then > LIBS=3D"$LIBS -lsocket" > fi > Index: configure.ac > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/gdbserver/configure.ac,v > retrieving revision 1.33 > diff -u -p -r1.33 configure.ac > --- configure.ac 23 Feb 2010 19:16:16 -0000 1.33 > +++ configure.ac 17 Apr 2010 05:25:59 -0000 > @@ -118,7 +118,7 @@ esac > if test "${srv_mingwce}" =3D "yes"; then > LIBS=3D"$LIBS -lws2" > elif test "${srv_mingw}" =3D "yes"; then > - LIBS=3D"$LIBS -lwsock32" > + LIBS=3D"$LIBS -lws2_32" > elif test "${srv_qnx}" =3D "yes"; then > LIBS=3D"$LIBS -lsocket" > fi > Index: gdbreplay.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/gdbserver/gdbreplay.c,v > retrieving revision 1.24 > diff -u -p -r1.24 gdbreplay.c > --- gdbreplay.c 1 Jan 2010 07:31:49 -0000 1.24 > +++ gdbreplay.c 17 Apr 2010 05:25:59 -0000 > @@ -59,7 +59,7 @@ > #endif >=20=20 > #if USE_WIN32API > -#include > +#include > #endif >=20=20 > #ifndef HAVE_SOCKLEN_T > Index: remote-utils.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/gdbserver/remote-utils.c,v > retrieving revision 1.72 > diff -u -p -r1.72 remote-utils.c > --- remote-utils.c 11 Apr 2010 16:33:56 -0000 1.72 > +++ remote-utils.c 17 Apr 2010 05:25:59 -0000 > @@ -63,7 +63,7 @@ > #endif >=20=20 > #if USE_WIN32API > -#include > +#include > #endif >=20=20 > #if __QNX__ >=20 >=20 --=20 Pedro Alves