From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11270 invoked by alias); 16 Apr 2010 15:48:12 -0000 Received: (qmail 11232 invoked by uid 22791); 16 Apr 2010 15:48:09 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Apr 2010 15:48:04 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3GFm2wD016578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 16 Apr 2010 11:48:02 -0400 Received: from psique.localnet (vpn-237-139.phx2.redhat.com [10.3.237.139]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3GFm26w008374; Fri, 16 Apr 2010 11:48:02 -0400 From: Sergio Durigan Junior To: Jan Kratochvil Subject: Re: [PATCH]: New `logical*8' type for Fortran Date: Fri, 16 Apr 2010 15:48:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.32.11-99.fc12.x86_64; KDE/4.4.1; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201004152001.22206.sergiodj@redhat.com> <20100416060916.GA29503@host0.dyn.jankratochvil.net> In-Reply-To: <20100416060916.GA29503@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004161248.00639.sergiodj@redhat.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00508.txt.bz2 On Friday 16 April 2010 03:09:16, Jan Kratochvil wrote: > Hi Sergio, Hello Jan, > On Fri, 16 Apr 2010 01:01:21 +0200, Sergio Durigan Junior wrote: > > This patch has been in our tree for a while and we would like to see it > > upstream. Jan asked me to take care of this, so I would like to post it > > for your appreciation. Comments are welcome as usual. > > sorry for follow-up from me: No problem. > > 2010-04-15 Jan Kratochvil > > > > * f-exp.y: Add new production to recognize the `logical*8' type. > > (LOGICAL_S8_KEYWORD): New token. > > > > * f-lang.c (enum f_primitive_types) > > : New field. > > (f_language_arch_info): Handling `logical*8' type. > > (build_fortran_types): Building `logical*8' type. > > > > * f-lang.h (builtin_logical_s8): New struct. > > It is a new field of struct builtin_f_type, not a new struct. Sorry for that. > > Also these changes depend each on the other so there should not be empty > lines between the changes. (6.8.2 Style of Change Logs) I'll fix that. > > gdb/testsuite/ChangeLog: > > > > 2010-04-15 Jan Kratochvil > > > > * gdb.fortran/logical.exp: New testcase. > > * gdb.fortran/logical.f90: New file. > > As you did some *.exp modifications you should list yourself here (in the > case you explicitly do not want to be listed there I do not know what the > rules are). I did really minor adjustments so I thought it wasn't worth listing my name, but I will fix it then. > > +++ b/gdb/testsuite/gdb.fortran/logical.exp > > +# Copyright 2007 Free Software Foundation, Inc. > > +++ b/gdb/testsuite/gdb.fortran/logical.f90 > > +! Copyright 2008 Free Software Foundation, Inc. > > The your should be changed as the patch was neither in FSF GDB nor in > Archer. Sorry, will fix that. > > +! Ihis file is the Fortran source file for dynamic.exp. > > This is not true. > > +! Original file written by Jakub Jelinek . > > This is not true (it was for dynamic.exp where the code size was not > trivial). Should I remove these lines then? > > +! Modified for the GDB testcase by Jan Kratochvil > > . > > Patch lines are corrupted (wrapped) by your MUA (mail user agent). Really? Darn... I will send it attached then, sorry for that. Thanks, -- Sergio