From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30072 invoked by alias); 15 Apr 2010 23:01:55 -0000 Received: (qmail 30021 invoked by uid 22791); 15 Apr 2010 23:01:54 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Apr 2010 23:01:49 +0000 Received: (qmail 25509 invoked from network); 15 Apr 2010 23:01:47 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Apr 2010 23:01:47 -0000 From: Pedro Alves To: Michael Snyder Subject: Re: PR8554: New command to save breakpoints to a file Date: Thu, 15 Apr 2010 23:01:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: "gdb-patches@sourceware.org" , "tromey@redhat.com" References: <201004090341.14389.pedro@codesourcery.com> <201004152058.06658.pedro@codesourcery.com> <4BC797FC.7040602@vmware.com> In-Reply-To: <4BC797FC.7040602@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004160001.44620.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00488.txt.bz2 On Thursday 15 April 2010 23:49:32, Michael Snyder wrote: > BTW. "save_command" needs to print an error or something, not > simply return without doing anything. If I type "save", > I get a silent failure. I think the common practice is to have it print "help save". At least, there are over 30 calls to help_list under gdb/ that look like that. E.g., (gdb) set print "set print" must be followed by the name of a print subcommand. List of set print subcommands: set print address -- Set printing of addresses ... I'll do that. I don't think we should bother with aliasing save to save-tracepoints, and it may even be annoying at some point. -- Pedro Alves