From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4158 invoked by alias); 15 Apr 2010 15:53:23 -0000 Received: (qmail 4148 invoked by uid 22791); 15 Apr 2010 15:53:22 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Apr 2010 15:53:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 336C82BAB9B; Thu, 15 Apr 2010 11:53:17 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id QAd1meUS9GxC; Thu, 15 Apr 2010 11:53:17 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CE9342BAAD0; Thu, 15 Apr 2010 11:53:16 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 43078F58C2; Thu, 15 Apr 2010 08:52:58 -0700 (PDT) Date: Thu, 15 Apr 2010 15:53:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: 'Pedro Alves' , gdb-patches@sourceware.org Subject: Re: [RFA] Fix compilation failure on cygwin due to ncurses macro. Message-ID: <20100415155258.GN19194@adacore.com> References: <003001cadae7$2e639860$8b2ac920$@muller@ics-cnrs.unistra.fr> <20100414155944.GK19194@adacore.com> <000001cadbef$a21bad70$e6530850$@muller@ics-cnrs.unistra.fr> <201004141738.22662.pedro@codesourcery.com> <000601cadc72$e751a330$b5f4e990$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000601cadc72$e751a330$b5f4e990$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00468.txt.bz2 > Thus it should become: > /* We need to cast the return value of wstandout to void because > in 2009/08/29 patch to release "5.7" of ncurses library, > the wstandout macro expands to code that generates a unused-value > warning at compilation. */ > > Is this correct? Sounds right to me - just one nit: I think it's "an unused-value" rather than "a unused...". Suggestion (which you are free to ignore): Would it make sense to define a new function or macro to have the cast (and therefore the comment) in only one place? -- Joel