From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8290 invoked by alias); 14 Apr 2010 00:39:50 -0000 Received: (qmail 8282 invoked by uid 22791); 14 Apr 2010 00:39:48 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=BAYES_00,TW_FP,TW_UF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Apr 2010 00:39:36 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 04EC51B404E; Wed, 14 Apr 2010 00:39:34 +0000 (UTC) From: Mike Frysinger To: Sandra Loosemore Subject: Re: [PATCH] sim: constify sim_write source buffer Date: Wed, 14 Apr 2010 00:39:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.33.2; KDE/4.4.1; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <4BC4FD92.8050308@codesourcery.com> In-Reply-To: <4BC4FD92.8050308@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2099555.FuSqjxAJYe"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201004132038.42551.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00438.txt.bz2 --nextPart2099555.FuSqjxAJYe Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 9683 On Tuesday 13 April 2010 19:26:10 Sandra Loosemore wrote: > FYI, this patch: >=20 > 2010-04-13 Mike Frysinger >=20 > * remote-sim.h (sim_write): Add const to buf arg. >=20 > caused the ARM simulator to fail to build. See sim/arm/wrapper.c:158: hmm, i didnt realize so many sim ports arent using the common/ code. the targets ive been testing all do. this patch should build fine for the targ= ets that otherwise work (seems like some have been marked for removal apparentl= y, and moxie requires some random "dtc" program). -mike arm/ 2010-04-13 Mike Frysinger * wrapper.c (sim_write): Add const to buffer arg. RCS file: /cvs/src/src/sim/arm/wrapper.c,v retrieving revision 1.38 diff -u -p -r1.38 wrapper.c --- sim/arm/wrapper.c 1 Jan 2010 10:03:26 -0000 1.38 +++ sim/arm/wrapper.c 14 Apr 2010 00:20:26 -0000 @@ -158,7 +158,7 @@ int sim_write (sd, addr, buffer, size) SIM_DESC sd ATTRIBUTE_UNUSED; SIM_ADDR addr; - unsigned char * buffer; + const unsigned char * buffer; int size; { int i; avr/ 2010-04-13 Mike Frysinger * interp.c (sim_write): Add const to buffer arg. RCS file: /cvs/src/src/sim/avr/interp.c,v retrieving revision 1.6 diff -u -p -r1.6 interp.c --- sim/avr/interp.c 1 Jan 2010 10:03:26 -0000 1.6 +++ sim/avr/interp.c 14 Apr 2010 00:20:26 -0000 @@ -1622,7 +1622,7 @@ sim_trace (SIM_DESC sd) } =20 int -sim_write (SIM_DESC sd, SIM_ADDR addr, unsigned char *buffer, int size) +sim_write (SIM_DESC sd, SIM_ADDR addr, const unsigned char *buffer, int si= ze) { int osize =3D size; =20 cr16/ 2010-04-13 Mike Frysinger * interp.c (sim_write): Add const to buffer arg. RCS file: /cvs/src/src/sim/cr16/interp.c,v retrieving revision 1.5 diff -u -p -r1.5 interp.c --- sim/cr16/interp.c 1 Jan 2010 10:03:27 -0000 1.5 +++ sim/cr16/interp.c 14 Apr 2010 00:20:26 -0000 @@ -883,7 +883,7 @@ int sim_write (sd, addr, buffer, size) SIM_DESC sd; SIM_ADDR addr; - unsigned char *buffer; + const unsigned char *buffer; int size; { /* FIXME: this should be performing a virtual transfer */ d10v/ 2010-04-13 Mike Frysinger * interp.c (sim_write): Add const to buffer arg. RCS file: /cvs/src/src/sim/d10v/interp.c,v retrieving revision 1.18 diff -u -p -r1.18 interp.c --- sim/d10v/interp.c 18 Apr 2006 09:15:29 -0000 1.18 +++ sim/d10v/interp.c 14 Apr 2010 00:20:26 -0000 @@ -761,7 +761,7 @@ int sim_write (sd, addr, buffer, size) SIM_DESC sd; SIM_ADDR addr; - unsigned char *buffer; + const unsigned char *buffer; int size; { /* FIXME: this should be performing a virtual transfer */ erc32/ 2010-04-13 Mike Frysinger * interp.c (sim_write): Add const to buf arg. RCS file: /cvs/src/src/sim/erc32/interf.c,v retrieving revision 1.6 diff -u -p -r1.6 interf.c --- sim/erc32/interf.c 28 Nov 2005 18:33:03 -0000 1.6 +++ sim/erc32/interf.c 14 Apr 2010 00:20:26 -0000 @@ -351,7 +351,7 @@ int sim_write(sd, mem, buf, length) SIM_DESC sd; SIM_ADDR mem; - unsigned char *buf; + const unsigned char *buf; int length; { return (sis_memory_write(mem, buf, length)); h8300/ 2010-04-13 Mike Frysinger * compile.c (sim_write): Add const to buffer arg. RCS file: /cvs/src/src/sim/h8300/compile.c,v retrieving revision 1.46 diff -u -p -r1.46 compile.c --- sim/h8300/compile.c 9 Dec 2009 05:32:16 -0000 1.46 +++ sim/h8300/compile.c 14 Apr 2010 00:20:26 -0000 @@ -4616,7 +4616,7 @@ sim_trace (SIM_DESC sd) } =20 int -sim_write (SIM_DESC sd, SIM_ADDR addr, unsigned char *buffer, int size) +sim_write (SIM_DESC sd, SIM_ADDR addr, const unsigned char *buffer, int si= ze) { int i; =20 m32c/ 2010-04-13 Mike Frysinger * gdb-if.c (sim_write): Add const to buf arg. * mem.h (mem_put_blk): Add const to bufptr arg. * mem.c (mem_put_blk): Likewise, and add const to cast. RCS file: /cvs/src/src/sim/m32c/gdb-if.c,v retrieving revision 1.9 diff -u -p -r1.9 gdb-if.c --- sim/m32c/gdb-if.c 1 Jan 2010 10:03:31 -0000 1.9 +++ sim/m32c/gdb-if.c 14 Apr 2010 00:20:26 -0000 @@ -167,7 +167,7 @@ sim_read (SIM_DESC sd, SIM_ADDR mem, uns } =20 int -sim_write (SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length) +sim_write (SIM_DESC sd, SIM_ADDR mem, const unsigned char *buf, int length) { check_desc (sd); =20 RCS file: /cvs/src/src/sim/m32c/mem.c,v retrieving revision 1.11 diff -u -p -r1.11 mem.c --- sim/m32c/mem.c 1 Jan 2010 10:03:31 -0000 1.11 +++ sim/m32c/mem.c 14 Apr 2010 00:34:30 -0000 @@ -365,13 +365,13 @@ mem_put_si (int address, unsigned long v } =20 void -mem_put_blk (int address, void *bufptr, int nbytes) +mem_put_blk (int address, const void *bufptr, int nbytes) { S ("<=3D"); if (enable_counting) mem_counters[1][1] +=3D nbytes; while (nbytes--) - mem_put_byte (address++, *(unsigned char *) bufptr++); + mem_put_byte (address++, *(const unsigned char *) bufptr++); E (); } =20 RCS file: /cvs/src/src/sim/m32c/mem.h,v retrieving revision 1.8 diff -u -p -r1.8 mem.h --- sim/m32c/mem.h 1 Jan 2010 10:03:31 -0000 1.8 +++ sim/m32c/mem.h 14 Apr 2010 00:34:30 -0000 @@ -27,7 +27,7 @@ void mem_put_hi (int address, unsigned s void mem_put_psi (int address, unsigned long value); void mem_put_si (int address, unsigned long value); =20 -void mem_put_blk (int address, void *bufptr, int nbytes); +void mem_put_blk (int address, const void *bufptr, int nbytes); =20 unsigned char mem_get_pc (); =20 mcore/ 2010-04-13 Mike Frysinger * interp.c (sim_write): Add const to buffer arg. RCS file: /cvs/src/src/sim/mcore/interp.c,v retrieving revision 1.12 diff -u -p -r1.12 interp.c --- sim/mcore/interp.c 1 Jan 2010 10:03:32 -0000 1.12 +++ sim/mcore/interp.c 14 Apr 2010 00:20:26 -0000 @@ -1718,7 +1718,7 @@ int sim_write (sd, addr, buffer, size) SIM_DESC sd; SIM_ADDR addr; - unsigned char * buffer; + const unsigned char * buffer; int size; { int i; microblaze/ 2010-04-13 Mike Frysinger * interp.c (sim_write): Add const to buffer arg. RCS file: /cvs/src/src/sim/microblaze/interp.c,v retrieving revision 1.3 diff -u -p -r1.3 interp.c --- sim/microblaze/interp.c 1 Jan 2010 10:03:32 -0000 1.3 +++ sim/microblaze/interp.c 14 Apr 2010 00:20:26 -0000 @@ -704,7 +704,7 @@ sim_resume (SIM_DESC sd, int step, int s =20 =20 int -sim_write (SIM_DESC sd, SIM_ADDR addr, unsigned char *buffer, int size) +sim_write (SIM_DESC sd, SIM_ADDR addr, const unsigned char *buffer, int si= ze) { int i; init_pointers (); mips/ 2010-04-13 Mike Frysinger * interp.c (sim_write): Add const to buffer arg. RCS file: /cvs/src/src/sim/mips/interp.c,v retrieving revision 1.25 diff -u -p -r1.25 interp.c --- sim/mips/interp.c 18 Jan 2010 03:30:28 -0000 1.25 +++ sim/mips/interp.c 14 Apr 2010 00:20:26 -0000 @@ -862,7 +862,7 @@ int sim_write (sd,addr,buffer,size) SIM_DESC sd; SIM_ADDR addr; - unsigned char *buffer; + const unsigned char *buffer; int size; { int index; moxie/ 2010-04-13 Mike Frysinger * interp.c (sim_write): Add const to buffer arg. RCS file: /cvs/src/src/sim/moxie/interp.c,v retrieving revision 1.10 diff -u -p -r1.10 interp.c --- sim/moxie/interp.c 27 Feb 2010 01:24:37 -0000 1.10 +++ sim/moxie/interp.c 14 Apr 2010 00:20:26 -0000 @@ -1028,7 +1028,7 @@ int sim_write (sd, addr, buffer, size) SIM_DESC sd; SIM_ADDR addr; - unsigned char * buffer; + const unsigned char * buffer; int size; { sim_cpu *scpu =3D STATE_CPU (sd, 0); /* FIXME */ ppc/ 2010-04-13 Mike Frysinger * sim_calls.c (sim_write): Add const to buf arg. RCS file: /cvs/src/src/sim/ppc/sim_calls.c,v retrieving revision 1.12 diff -u -p -r1.12 sim_calls.c --- sim/ppc/sim_calls.c 28 Nov 2005 18:33:03 -0000 1.12 +++ sim/ppc/sim_calls.c 14 Apr 2010 00:20:26 -0000 @@ -144,7 +144,7 @@ sim_read (SIM_DESC sd, SIM_ADDR mem, uns =20 =20 int -sim_write (SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length) +sim_write (SIM_DESC sd, SIM_ADDR mem, const unsigned char *buf, int length) { int result =3D psim_write_memory(simulator, MAX_NR_PROCESSORS, buf, mem, length, rx/ 2010-04-13 Mike Frysinger * gdb-if.c (sim_write): Add const to buf arg. RCS file: /cvs/src/src/sim/rx/gdb-if.c,v retrieving revision 1.2 diff -u -p -r1.2 gdb-if.c --- sim/rx/gdb-if.c 1 Jan 2010 10:03:33 -0000 1.2 +++ sim/rx/gdb-if.c 14 Apr 2010 00:20:26 -0000 @@ -245,7 +245,7 @@ sim_read (SIM_DESC sd, SIM_ADDR mem, uns } =20 int -sim_write (SIM_DESC sd, SIM_ADDR mem, unsigned char *buf, int length) +sim_write (SIM_DESC sd, SIM_ADDR mem, const unsigned char *buf, int length) { int i; =20 sh/ 2010-04-13 Mike Frysinger * interp.c (sim_write): Add const to buffer arg. RCS file: /cvs/src/src/sim/sh/interp.c,v retrieving revision 1.21 diff -u -p -r1.21 interp.c --- sim/sh/interp.c 14 Feb 2010 07:15:57 -0000 1.21 +++ sim/sh/interp.c 14 Apr 2010 00:20:26 -0000 @@ -81,7 +81,7 @@ =20 extern unsigned short sh_jump_table[], sh_dsp_table[0x1000], ppi_table[]; =20 -int sim_write (SIM_DESC sd, SIM_ADDR addr, unsigned char *buffer, int size= ); +int sim_write (SIM_DESC sd, SIM_ADDR addr, const unsigned char *buffer, in= t size); =20 #define O_RECOMPILE 85 #define DEFINE_TABLE @@ -2141,7 +2141,7 @@ int sim_write (sd, addr, buffer, size) SIM_DESC sd; SIM_ADDR addr; - unsigned char *buffer; + const unsigned char *buffer; int size; { int i; --nextPart2099555.FuSqjxAJYe Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLxQ6SAAoJEEFjO5/oN/WBSHEQALbb0zaVnlG6UIRVu69TbCkD 2m2e5nf2aT0cpQLu31iKnxz9Q+ofJPwbEc9oQmg49A4CIQXWqMdc2bDXL4c6wXNP FM6hjpGJ89Y+iC+kiWjNp6sji4Fp2wAY524mSFFNdNkftZh9m1Zv+lG8UOFaTnLE i4vGsVe3XZBbjBF/fI+RSZWApoBjjkv3sgD+D5bp3mJ88r+pll3afTI1CvvCaMOF D/ufmtEH0QRN2eBoy1AMgO/2HgYRM/LX1UnJJrYAZAHIp52zTYHyoPRxe04cuLul BRkwONjq46D0AwP5iVHjP0llBhut5GP+rv1KzXntZ8/X3gD+HX7hDNprmmiBdrP7 b4ySn6+7M78nUi76lIx6IQUIxFzgwdI5x29h7t0abyqsb4N9TDuEYX4V4idsVKqy lf5oaDIlx3ehsSQONtTzdkp5DxW93DQmEBFiOdJKel1EurdrLnGp/9ag04U0Vv5c FFJJkzixbexOTne6rjnD+fCx7uNac1c+t1EpsWfODI8t3q3SYD6G7pBmNzrDU4U+ Tb/GX0m3ruLdVihlY7i4ONT1/ek6owbVs322E9ASX+n/fM0gyO20S0drm84fi3QH iSVhBzAgc13Nsjcn4ZS+WEpH1SagefDkMEfYQtF21TuseGRqrfd/o4MxgG9WGoyg YHE+EvM4jA1fwXqmKQIc =06gH -----END PGP SIGNATURE----- --nextPart2099555.FuSqjxAJYe--