From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: 'Pedro Alves' <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix compilation failure on cygwin due to ncurses macro.
Date: Tue, 13 Apr 2010 15:07:00 -0000 [thread overview]
Message-ID: <20100413150707.GE19194@adacore.com> (raw)
In-Reply-To: <004201cadb02$b4a525e0$1def71a0$@muller@ics-cnrs.unistra.fr>
> Committed with your corrections.
Just a request: Can you add a comment next to all the casts explaining
why the cast is there? It's important so that someone seeing the cast
does not scratch his head for too long...
Thank you,
--
Joel
next prev parent reply other threads:[~2010-04-13 15:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 8:56 Pierre Muller
2010-04-13 11:38 ` Pedro Alves
2010-04-13 12:13 ` Pierre Muller
2010-04-13 15:07 ` Joel Brobecker [this message]
2010-04-13 15:17 ` Pierre Muller
2010-04-13 15:26 ` Joel Brobecker
2010-04-14 11:08 ` Pierre Muller
2010-04-14 16:00 ` Joel Brobecker
2010-04-14 16:30 ` Pierre Muller
2010-04-14 16:33 ` Joel Brobecker
2010-04-14 16:39 ` Pedro Alves
2010-04-15 8:09 ` Pierre Muller
2010-04-15 15:53 ` Joel Brobecker
2010-04-15 22:38 ` [RFC] Use macro for void typecast necessary for ncurses library Pierre Muller
2010-04-16 4:36 ` Joel Brobecker
[not found] ` <9120.2086922296$1271371097@news.gmane.org>
2010-04-20 15:45 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100413150707.GE19194@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox