From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5686 invoked by alias); 13 Apr 2010 03:05:35 -0000 Received: (qmail 5675 invoked by uid 22791); 13 Apr 2010 03:05:33 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Apr 2010 03:05:27 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id BE6A31B4039; Tue, 13 Apr 2010 03:05:25 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [PATCH] Do partial xfers from trace file Date: Tue, 13 Apr 2010 03:05:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.33.2; KDE/4.4.1; x86_64; ; ) Cc: Stan Shebs References: <4BBA5FE9.2060508@codesourcery.com> In-Reply-To: <4BBA5FE9.2060508@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2196911.ROoVE1TeCc"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201004122304.39043.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00393.txt.bz2 --nextPart2196911.ROoVE1TeCc Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 1178 On Monday 05 April 2010 18:10:49 Stan Shebs wrote: > Memory blocks in the trace buffer are limited to 65K (to save a couple > bytes in the length field, since most blocks are small), and a tester > trying to collect a quarter-megabyte(!) C++ object ran into trouble with > that. The fix is really a target-side thing, but the trace file reader > needs to cognizant of this detail also. Fortunately, we can exploit > GDB's partial xfer mechanism, and just return what we find in one block, > expecting that GDB will re-request the remainder. >=20 > I also made the tfile target has_all_memory, and added an emulation of > QTro behavior, which lets disassembly and the like work, but rejects > attempts to print non-constant globals that were not collected. > Committed to trunk. there's some problems with this commit ... it introduces a warning which breaks with -Werror: tracepoint.c: In function =E2=80=98tfile_xfer_partial=E2=80=99: tracepoint.c:3895: error: ignoring return value of =E2=80=98read=E2=80=99, = declared with=20 attribute warn_unused_result that particular piece of code also has slightly broken whitespace: ....... -mike --nextPart2196911.ROoVE1TeCc Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLw99GAAoJEEFjO5/oN/WBtJkP/1CKRxZnAmshNPrCeEpFyfa1 274tTkvCqoumzpueSZ1cwAMuBgI7OWWRcYkNNWGvC+nTY1KUMpt0zDXtiyEmBS0W oU9RvjgQhMnEaVYVTG/61nkOTWj6LwGVQoMkDMhiyI+nrsbbrE+iKhKDrfC1/vio lFOkXyFYX1EqX7f0D6/X9/1B1Xy1IuBmQyNVC9Rpt+CXqh+hxAc3Ra0HJzfcTVQr r9S3+VXqgqCx5wyYyjttvQkHpXZ5kTBPWeYZSHHyPE+2msXAgJMXSnxZZ2aEZA9F i5/lsYUa1Wf/qt9Gp37v3f3QJhaz2coOOWsVNXgHl7zx6lWevpGA/hT45wZFSjRU FnZx/onVYsNlKqD05aSL438mhTNyTWynasUJi0OY/BhthTlh3CMRKCNYZFUehUZZ KbTMH3t1HZXP4SvhfXlczkbEsD0qNcRPA2uwmxH1yHuxtloBhfbN5F4qRSCCY4eY +zSSZAJLjaxCldfXhEjNIJbTJJmJhMhUDQXbC2CpuXSM8XAtxEaP005KpOd85Avc Fz8ysNVYeytUi0MSmBHCFJ/r9qoKDeZd9sIcQRB/SlXjVU6XXOkdu/pZ+SNM/KPl 5L8+H6EIGE0lepg+6bSEqdP8c7Rxnpjm5bLHJ4f5WfJ/4atJ81LxQ9+Ao8Os4A/S 2GS8vGNBGxLzBVdbXm0g =HFT/ -----END PGP SIGNATURE----- --nextPart2196911.ROoVE1TeCc--