Re: [PATCH] sim: add helper macros for branch profiling

Joel Brobecker
2010-04-12T16:09:47Z

> > > 2010-04-10 Mike Frysinger <vapier@gentoo.org>
> > >
> > > * sim-profile.h (PROFILE_BRANCH_TAKEN, PROFILE_BRANCH_UNTAKEN): New
> > > defines.
> >
> > Forgive my ignorance, but are these macros going to be automatically
> > used? Or is there another patch in the pipeline that makes use of them?
>
> i'm using them in the Blackfin sim. once i can get the Blackfin FDPIC shared
> lib stuff working with latest GDB again, i'll post that patch series.

OK - after some thoughts, I think it's fine for you to check the code in,
even if it's unused. I usually don't like that, but since you already
posted the patch, hopefully it won't be too long before you start using it.
The risk you're exposing yourself to is that someones figures out that
it's unused, and just removes it. But I think it's very remote, at least
in the simulator code.

--
Joel