From: Mike Frysinger <vapier@gentoo.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: tweak signed to unsigned local vars
Date: Mon, 12 Apr 2010 18:45:00 -0000 [thread overview]
Message-ID: <201004121444.58803.vapier@gentoo.org> (raw)
In-Reply-To: <20100412152413.GV19194@adacore.com>
[-- Attachment #1: Type: Text/Plain, Size: 723 bytes --]
On Monday 12 April 2010 11:24:13 Joel Brobecker wrote:
> > @@ -583,7 +583,7 @@ hw_add_range_array_property (struct hw *me,
> >
> > * sizeof (unsigned_cell));
> >
> > unsigned_cell *cells = hw_zalloc (me, sizeof_cells);
> > unsigned_cell *cell;
> >
> > - int i;
> > + unsigned i;
>
> I am not sure about this one either. Can you try changing the type
> of parameter nr_ranges to int? It looks like the only usage of this
> function is in hw-tree, and the variable used is actually an int...
the relevant funcs involved here seem like they should all be converted to
unsigned. in the event of an error, they abort, and only ever return unsigned
values. i'll go that route.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2010-04-12 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 21:58 Mike Frysinger
2010-04-12 15:24 ` Joel Brobecker
2010-04-12 15:52 ` Mike Frysinger
2010-04-12 16:06 ` Joel Brobecker
2010-04-12 18:30 ` Mike Frysinger
2010-04-12 19:59 ` Joel Brobecker
2010-04-12 18:45 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004121444.58803.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox