From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: Re: [patch] sim: constify sim_fpu_print_status
Date: Sat, 10 Apr 2010 21:25:00 -0000 [thread overview]
Message-ID: <201004101724.50225.vapier@gentoo.org> (raw)
In-Reply-To: <201004101629.28634.vapier@gentoo.org>
[-- Attachment #1: Type: Text/Plain, Size: 1293 bytes --]
On Saturday 10 April 2010 16:29:28 Mike Frysinger wrote:
> I've committed the following patch as obvious. The local "prefix" variable
> is only assigned const strings, and only passed to printf() functions, so
> add "const" to avoid gcc warnings:
> common/sim-fpu.c: In function 'sim_fpu_print_status':
> common/sim-fpu.c:2508: warning: initialization discards qualifiers from
> pointer target type
> common/sim-fpu.c:2566: warning: assignment discards qualifiers from pointer
> target type
blah, this takes it a little out of the "obvious" range, but i forgot to
include this hunk. hopefully it doesnt cause problems :/.
2010-04-10 Mike Frysinger <vapier@gentoo.org>
* sim-fpu.c (sim_fpu_print_func): Add const markings to format buffer.
RCS file: /cvs/src/src/sim/common/sim-fpu.h,v
retrieving revision 1.15
diff -u -p -r1.15 sim-fpu.h
--- sim/common/sim-fpu.h 1 Jan 2010 10:03:27 -0000 1.15
+++ sim/common/sim-fpu.h 10 Apr 2010 21:22:23 -0000
@@ -404,7 +404,7 @@ extern const sim_fpu sim_fpu_max64;
/* For debugging */
-typedef void sim_fpu_print_func (void *, char *, ...);
+typedef void sim_fpu_print_func (void *, const char *, ...);
/* Print a sim_fpu with full precision. */
INLINE_SIM_FPU (void) sim_fpu_print_fpu (const sim_fpu *f,
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2010-04-10 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-10 20:29 Mike Frysinger
2010-04-10 21:25 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004101724.50225.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox