From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71935-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15715 invoked by alias); 9 Apr 2010 16:02:25 -0000
Received: (qmail 15651 invoked by uid 22791); 9 Apr 2010 16:02:24 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 16:02:20 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) 	by filtered-rock.gnat.com (Postfix) with ESMTP id 4773A2BABBA; 	Fri,  9 Apr 2010 12:02:18 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1]) 	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) 	with LMTP id ltfA1Nw0afLs; Fri,  9 Apr 2010 12:02:18 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) 	by rock.gnat.com (Postfix) with ESMTP id 18C1E2BABB9; 	Fri,  9 Apr 2010 12:02:17 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id 28758F58C2; Fri,  9 Apr 2010 09:02:08 -0700 (PDT)
Date: Fri, 09 Apr 2010 16:02:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: "H.J. Lu" <hongjiu.lu@intel.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: PR corefiles/11481: gcore doesn't work on i386 without  SSE
Message-ID: <20100409160208.GP19194@adacore.com>
References: <20100409155012.GA19118@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100409155012.GA19118@intel.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00254.txt.bz2

Mark already answered, but I noticed something that was perhaps worth
a suggestion:

> +  if (i386_linux_regset_sections[i].sect_name == NULL)
> +    internal_error (__FILE__, __LINE__,
> +		    _("invalid core regset secion %s"), name);

In this sort of situation (something that should never happen unless
there is a programming error in GDB), you might prefer the use of
gdb_assert.

-- 
Joel