From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21633 invoked by alias); 9 Apr 2010 15:53:11 -0000 Received: (qmail 21619 invoked by uid 22791); 9 Apr 2010 15:53:09 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 15:53:03 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o39Fqqde024235 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 9 Apr 2010 11:52:52 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o39FqoPc020064 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 9 Apr 2010 11:52:52 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o39Fqone011863; Fri, 9 Apr 2010 17:52:50 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o39FqnFA011862; Fri, 9 Apr 2010 17:52:49 +0200 Date: Fri, 09 Apr 2010 15:53:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [patch] Fix dangling displays in separate debug Message-ID: <20100409155249.GA11583@host0.dyn.jankratochvil.net> References: <20100403095558.GA22520@host0.dyn.jankratochvil.net> <20100409153014.GA10379@host0.dyn.jankratochvil.net> <201004091634.01221.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201004091634.01221.pedro@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00250.txt.bz2 On Fri, 09 Apr 2010 17:34:01 +0200, Pedro Alves wrote: > On Friday 09 April 2010 16:30:14, Jan Kratochvil wrote: > > Unaware how to improve it more. > > Would using objfile_separate_debug_iterate be better? In this case we are examining `struct expression *'. EXP contains `struct symbol *'. SYMBOL points to `struct objfile *' of the separate debug info file. If SYMBOL points to `struct objfile *' of the main binary, it is equal to SOLIB->OBJFILE and it has been already checked before. The main binary -> separate debug info direction provided by the iterating functionality of objfile_separate_debug_iterate is not useful in this case. I cannot not say I like this design but its rework I have not completed to the check-in before: [patch 1/8] Types GC [unloading observer] http://sourceware.org/ml/gdb-patches/2009-05/msg00544.html Re: [patch 3/8] Types GC [display_uses_solib_p to exp_iterate] http://sourceware.org/ml/gdb-patches/2009-07/msg00054.html If continuing hacks of the current code is not acceptable it can wait till / I can push the proper reimplementation of this code from the old thread above. Thanks, Jan