From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4598 invoked by alias); 8 Apr 2010 23:09:13 -0000 Received: (qmail 4589 invoked by uid 22791); 8 Apr 2010 23:09:12 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Apr 2010 23:09:07 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o38N8xTj026656 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 Apr 2010 19:09:00 -0400 Received: from psique.localnet (vpn-236-226.phx2.redhat.com [10.3.236.226]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o38N8v2V032654; Thu, 8 Apr 2010 19:08:57 -0400 From: Sergio Durigan Junior To: gdb-patches@sourceware.org Subject: Re: [RFA] Add -s option to source command. Date: Thu, 08 Apr 2010 23:09:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.32.9-70.fc12.x86_64; KDE/4.4.1; x86_64; ; ) Cc: Doug Evans , tromey@redhat.com References: <20100406215751.7EC1784397@ruffy.mtv.corp.google.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Message-Id: <201004082008.55981.sergiodj@redhat.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00208.txt.bz2 On Thursday 08 April 2010 19:49:41, Doug Evans wrote: > On Wed, Apr 7, 2010 at 1:14 PM, Tom Tromey wrote: > > I often wish that gdb help strings were formatted more like --help > > output. > > > > Tom > > Something like this? > > @@ -1379,8 +1437,12 @@ Commands defined in this way may have up > > source_help_text = xstrprintf (_("\ > Read commands from a file named FILE.\n\ > -Optional -v switch (before the filename) causes each command in\n\ > -FILE to be echoed as it is executed.\n\ > +\n\ > +Usage: source [-s] [-v] FILE\n\ > +-s: search for the script in the source search path,\n\ > + even if FILE contains directories.\n\ > +-v: each command in FILE is echoed as it is executed.\n\ > +\n\ > Note that the file \"%s\" is read automatically in this way\n\ > when GDB is started."), gdbinit); > c = add_cmd ("source", class_support, source_command, I totally agree with Tom here, but I don't know if it's a good thing to change the "standard" only in this feature without converting the other GDB help strings as well. IMHO if we are going to start formatting the help strings like `--help' output, then we should do it for the majority (if not all) of the strings. Anyway, my half cent here. -- Sergio Durigan Junior Debugger Engineer Red Hat Inc.