From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12346 invoked by alias); 7 Apr 2010 21:19:24 -0000 Received: (qmail 12337 invoked by uid 22791); 7 Apr 2010 21:19:23 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Apr 2010 21:19:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5796E2BABA6; Wed, 7 Apr 2010 17:19:18 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kPPI64VhZy2Q; Wed, 7 Apr 2010 17:19:18 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 08DC62BABA1; Wed, 7 Apr 2010 17:19:17 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id C4476F58C2; Wed, 7 Apr 2010 14:19:10 -0700 (PDT) Date: Wed, 07 Apr 2010 21:19:00 -0000 From: Joel Brobecker To: Phil Muldoon Cc: gdb-patches ml , Eli Zaretskii Subject: Re: [patch][python] Add breakpoint support. Message-ID: <20100407211910.GJ19194@adacore.com> References: <4BB0B063.6000600@redhat.com> <20100405162648.GD19194@adacore.com> <4BBB3AF6.8050407@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4BBB3AF6.8050407@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00164.txt.bz2 Just one nit that I could see: > + else > + { > + PyErr_SetString (PyExc_TypeError, > + _("The value of `ask' must be an integer or None.")); ^^^^ task Apart from that, no other comment on my end... -- Joel