From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11121 invoked by alias); 7 Apr 2010 05:33:20 -0000 Received: (qmail 11113 invoked by uid 22791); 7 Apr 2010 05:33:19 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Apr 2010 05:33:16 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A16E72BAB11; Wed, 7 Apr 2010 01:33:14 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id q2zMd7deoD0O; Wed, 7 Apr 2010 01:33:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6ED342BAB2C; Wed, 7 Apr 2010 01:33:14 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 0AB07F58C2; Tue, 6 Apr 2010 22:33:08 -0700 (PDT) Date: Wed, 07 Apr 2010 05:33:00 -0000 From: Joel Brobecker To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] Make source_file_name const char *. Message-ID: <20100407053308.GH19194@adacore.com> References: <20100406194845.F12F784397@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100406194845.F12F784397@ruffy.mtv.corp.google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00119.txt.bz2 > I will check this patch in in a few days if there are no objections. > It just adds const to source_file_name. I'd say go ahead. I think your patch is an improvement, and at worst, it's so easy to revert that it's not worth the pain of waiting for potential objections (IMO). -- Joel