From: Joel Brobecker <brobecker@adacore.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Use vectors in uploaded tracepoints
Date: Mon, 05 Apr 2010 20:51:00 -0000 [thread overview]
Message-ID: <20100405205028.GF19194@adacore.com> (raw)
In-Reply-To: <4BBA3E00.7060508@codesourcery.com>
FWIW...
> 1. This is now the third place that has a "char_ptr" typedef for use
> with vectors. Is there any reason not to consolidate into one
> typedef in defs.h?
Certainly no objection on this end, although the benefits seem to be
pretty small. Perhaps it would make even better sense if we added both
the char_ptr and the vector definition? Would that have any negative
effect in terms of amount of code?
> 2. Should it be renamed to "char_p"? There is a quasi-standard of
> using "_s" for struct and "_p" for pointer typedefs for vectors; but
> "char_p" seems a little cryptic to me.
If char_p is defined together with the associated vector, then I don't
mind it. But defined on its own, I agree char_ptr is better.
(not that it really matters all that much...)
--
Joel
next prev parent reply other threads:[~2010-04-05 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 19:46 Stan Shebs
2010-04-05 20:51 ` Joel Brobecker [this message]
2010-04-05 22:24 ` Stan Shebs
2010-04-07 5:25 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100405205028.GF19194@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox