From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25854 invoked by alias); 3 Apr 2010 09:56:27 -0000 Received: (qmail 25766 invoked by uid 22791); 3 Apr 2010 09:56:10 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 03 Apr 2010 09:56:04 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o339u2Qj017689 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 3 Apr 2010 05:56:02 -0400 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o339txbe030870 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 3 Apr 2010 05:56:01 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o339tx6f022624 for ; Sat, 3 Apr 2010 11:55:59 +0200 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o339twmD022623 for gdb-patches@sourceware.org; Sat, 3 Apr 2010 11:55:58 +0200 Date: Sat, 03 Apr 2010 09:56:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch] Fix dangling displays in separate debug Message-ID: <20100403095558.GA22520@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00055.txt.bz2 Hi, gdb.base/solib-display.exp using _separate_ debug info: 3: c_global = gdbtypes.c:1369: internal-error: check_typedef: Assertion `type' failed. A problem internal to GDB has been detected, This problem was fixed before by: [patch 1/8] Types GC [unloading observer] http://sourceware.org/ml/gdb-patches/2009-05/msg00544.html Re: [patch 3/8] Types GC [display_uses_solib_p to exp_iterate] http://sourceware.org/ml/gdb-patches/2009-07/msg00054.html but as that patchset is still not in providing this temporary fixup instead. One may only address that gdb.base/solib-display.exp was testing symbol in-objfile while now it tests only symbol in-sepdebug-objfile and no longer the in-objfile case. I find the in-sepdebug-objfile as a superset of in-objfile test but I can rework it if anyones addresses this test change. No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu. Thanks, Jan gdb/ 2010-04-03 Jan Kratochvil * printcmd.c (display_uses_solib_p): Check also SEPARATE_DEBUG_OBJFILE. gdb/testsuite/ 2010-04-03 Jan Kratochvil * gdb.base/solib-display.exp (split solib): New. --- a/gdb/printcmd.c +++ b/gdb/printcmd.c @@ -1895,7 +1895,9 @@ display_uses_solib_p (const struct display *d, return 1; /* SYMBOL_OBJ_SECTION (symbol) may be NULL. */ - if (SYMBOL_SYMTAB (symbol)->objfile == solib->objfile) + if (SYMBOL_SYMTAB (symbol)->objfile == solib->objfile + || SYMBOL_SYMTAB (symbol)->objfile + == solib->objfile->separate_debug_objfile) return 1; } endpos -= oplen; --- a/gdb/testsuite/gdb.base/solib-display.exp +++ b/gdb/testsuite/gdb.base/solib-display.exp @@ -53,6 +53,13 @@ if { [gdb_compile_shlib ${srcfile_lib} ${binfile_lib} $lib_flags] != "" return -1 } +set test "split solib" +if {[gdb_gnu_strip_debug $binfile_lib] != 0} { + fail $test +} else { + pass $test +} + gdb_exit gdb_start gdb_reinitialize_dir $srcdir/$subdir