From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4679 invoked by alias); 1 Apr 2010 22:51:41 -0000 Received: (qmail 4631 invoked by uid 22791); 1 Apr 2010 22:51:29 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=BAYES_00,TW_XS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Apr 2010 22:51:24 +0000 Received: (qmail 24177 invoked from network); 1 Apr 2010 22:51:22 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Apr 2010 22:51:22 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Missing 0x in phex_nz output Date: Thu, 01 Apr 2010 22:51:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: "H.J. Lu" References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004012351.20183.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00032.txt.bz2 On Thursday 01 April 2010 23:42:13, H.J. Lu wrote: > phex_nz returns a string of hex number. But 0x is missing in many outputs: > > m32r-rom.c: monitor_printf ("%s mw\r", phex_nz (section_base, addr_size)); > monitor.c: monitor_printf ("%s\r", phex_nz (val, reg_size)); > monitor.c: monitor_printf ("%s\r", phex_nz (val, reg_size)); > remote.c: xsnprintf (buf, get_remote_packet_size (), "P%s=", phex_nz > (reg->pnum, 0)); > remote.c: sprintf (p, "pc:%s", phex_nz (addr1, 0)); > remote.c: sprintf (p, "range:%s:%s", phex_nz (addr1, 0), phex_nz > (addr2, 0)); > remote.c: sprintf (p, "outside:%s:%s", phex_nz (addr1, 0), > phex_nz (addr2, 0)); These all are building remote|monitor protocol strings, not user visible output. It's a protocol requirement that they don't have the 0x prefix. > scm-valprint.c: fprintf_filtered (stream, " #X%s>", phex_nz > (svalue, SCM_SIZE)); No idea what this is, but I bet the #X prefix has some "hex" meaning already. -- Pedro Alves