From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20745 invoked by alias); 30 Mar 2010 22:39:36 -0000 Received: (qmail 20733 invoked by uid 22791); 30 Mar 2010 22:39:35 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Mar 2010 22:39:31 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 5677A1B40ED; Tue, 30 Mar 2010 22:39:29 +0000 (UTC) From: Mike Frysinger To: tromey@redhat.com Subject: Re: [PATCH v2] sim: use socklen_t with accept() Date: Tue, 30 Mar 2010 22:39:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.33.1; KDE/4.4.1; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <1269986875-1519-1-git-send-email-vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1304051.qntKqcYuGK"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201003301839.19240.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg01092.txt.bz2 --nextPart1304051.qntKqcYuGK Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1276 On Tuesday 30 March 2010 18:21:55 Tom Tromey wrote: > >>>>> "Mike" =3D=3D Mike Frysinger writes: > Mike> 2010-03-30 Mike Frysinger > Mike> * configure.ac: Check for socklen_t. > Mike> * configure, config.in: Regenerated. > Mike> * dv-sockser.c (connected_p): Change addrlen type to socklen_t. >=20 > Somewhere, probably dv-sockser.c, you also need this bit: >=20 > #ifndef HAVE_SOCKLEN_T > typedef int socklen_t; > #endif i would have thought the configure code people were using would take care o= f=20 this, but oh well. > Mike> Note: this config.in diffstat is larger because the regen tweaked t= he > Mike> comment style for a lot of defines ... not sure if this is > correct >=20 > Make sure you use the exact same versions of the autotools as currently > used in the tree. I download the canonical versions from gnu.org and > install them all in a fresh $prefix for gdb hacking. You can't use > different versions (even minor versions) or distro variants, as they > cause churn in the repository. right, trying to do otherwise gave me an error about wanting exactly 2.64. = so=20 i installed that version but still saw the churn. i'll include the changes= in=20 the next patch so you can see what i mean. -mike --nextPart1304051.qntKqcYuGK Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLsn2XAAoJEEFjO5/oN/WBY/QQAMjGDWqOPHyooGNcy48GzUPA fpS6lQgUhmUPYSJ3XPHGz6BUjjwanaNAQhbasDBMD5u3q8Vn7spN2P/yRAoAE0BJ a/ZN8ztrX7c3K0IDkftmG+0X0GI9IgT4H98V87kxjU+wnup8ark8AsZS+3WR9QG0 u0RQZL5/XY9yAFFCzKwkCTgYPqLmmEybvQXkqh4hMr2ye8jkI213dOZwCKM3nh7Z OSr3uZYdjF4psi4XQ5aqcalfAif/uF7S5oenIBUadtGuGx2rgJz3bsKk+hyOSbud T/adLA8GiFGGlBCj4DMZ7D9GWxdUNJGvuLr24x0TxK08JsITHliT8MMoHSiqsIBi KITOoIyItjjsob3+ynfxp3hEXa+X8NCjLiGkGLX9LdMjxY8WiO3riVB1ZiG7m/zy tcR1WcHtu18Dhx+JIQy2PHroksIi1nE1mjtI4/zJdg+UF0G5muWgm3V6sGM9k/ye KqBOBDDt9+kBsXEf91aF3Nagu4ZoeRvv65PVk/ciup5Gvc/6FohRga0KQwnwsLeG UIE83TOugDPCg4uymNrZLn3dD+ytalz7CmvmBeGm0gxusC+8VJOjx6M666NN/wzc /BebxVK4LnRfwP5eWvZRAirYJLNuCs9BcOib0S1ugMZGBiq1iNQwbYwYOAOcpyEq RLiFFZRURXh2tjDNQx1s =v/T/ -----END PGP SIGNATURE----- --nextPart1304051.qntKqcYuGK--