From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24718 invoked by alias); 28 Mar 2010 19:01:44 -0000 Received: (qmail 24623 invoked by uid 22791); 28 Mar 2010 19:01:43 -0000 X-Spam-Check-By: sourceware.org Received: from pool-173-76-55-5.bstnma.fios.verizon.net (HELO cgf.cx) (173.76.55.5) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Sun, 28 Mar 2010 19:01:35 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id 7200013C061; Sun, 28 Mar 2010 15:01:33 -0400 (EDT) Received: by ednor.cgf.cx (Postfix, from userid 201) id 6B7F82B352; Sun, 28 Mar 2010 15:01:33 -0400 (EDT) Date: Sun, 28 Mar 2010 19:01:00 -0000 From: Christopher Faylor To: Daniel Jacobowitz , ktietz70@googlemail.com, Ozkan Sezer , gdb-patches@sources.redhat.com Subject: Re: [PATCH] winsock include fixes Message-ID: <20100328190133.GA32263@ednor.casa.cgf.cx> Mail-Followup-To: Daniel Jacobowitz , ktietz70@googlemail.com, Ozkan Sezer , gdb-patches@sources.redhat.com References: <647fe9b11003260354o53df5f0ayde8d1e3a03f1b694@mail.gmail.com> <20100326141655.GA23473@caradoc.them.org> <647fe9b11003260747i3156003fp642e9ed6ae74d7b5@mail.gmail.com> <647fe9b11003260824o4fb82825n22ca8cdf5da0f1e6@mail.gmail.com> <20100326153302.GI9310@caradoc.them.org> <20100328184323.GA32194@ednor.casa.cgf.cx> <647fe9b11003281148u489bb801oabb0c7bd6d4438e7@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <647fe9b11003281148u489bb801oabb0c7bd6d4438e7@mail.gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00953.txt.bz2 On Sun, Mar 28, 2010 at 09:48:04PM +0300, Ozkan Sezer wrote: >On Sun, Mar 28, 2010 at 9:43 PM, Christopher Faylor wrote: >> On Fri, Mar 26, 2010 at 11:33:02AM -0400, Daniel Jacobowitz wrote: >>>On Fri, Mar 26, 2010 at 05:24:23PM +0200, Ozkan Sezer wrote: >>>> Indeed, adding winsock2.h include to serial.h does fix the >>>> problems for mingw-w64, like the following: >>> >>>This change is OK. >> >> Isn't this really a problem with mingw-w64 rather than a gdb >> problem? ?It seems like this should be fixed there. > >I posted the fix to gdb, because I believe that it is a gdb problem. >Can you explain how is it really supposed to be a mingw-w64 problem? Actually, nevermind. I've just googled this and it seems like including winsock2.h first is the accepted solution even for regular Visual C. cgf