From: Joel Brobecker <brobecker@adacore.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't trace if all tracepoints disabled
Date: Fri, 26 Mar 2010 23:56:00 -0000 [thread overview]
Message-ID: <20100326235640.GA4257@adacore.com> (raw)
In-Reply-To: <4BAD1ED2.5090501@codesourcery.com>
> This patch simply requires that there be at least one enabled
> tracepoint before a trace run will start. While it's not
> necessarily wrong to have a tracepoint-less trace run, this could
> save a user or two from massive puzzlement as to why there are no
> trace frames accumulating. :-) While this seems uncontroversial,
> I'm going to hold off commit to allow comments.
It seems to me that, from a user's perspective, a trace run without
tracepoints would be pointless, right? So, if a user request a trace
run without any tracepoint, he most likely made a mistake somewhere
(wrong command or forgot to create the tracepoints). So I agree with
your suggestion (FWIW).
--
Joel
prev parent reply other threads:[~2010-03-26 23:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 20:53 Stan Shebs
2010-03-26 23:56 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326235640.GA4257@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox