From: Daniel Jacobowitz <dan@codesourcery.com>
To: Ozkan Sezer <sezeroz@gmail.com>
Cc: gdb-patches@sources.redhat.com, ktietz70@googlemail.com
Subject: Re: [PATCH] winsock include fixes
Date: Fri, 26 Mar 2010 14:17:00 -0000 [thread overview]
Message-ID: <20100326141655.GA23473@caradoc.them.org> (raw)
In-Reply-To: <647fe9b11003260354o53df5f0ayde8d1e3a03f1b694@mail.gmail.com>
On Fri, Mar 26, 2010 at 12:54:10PM +0200, Ozkan Sezer wrote:
> Hi: Here is a patch fixing the winsock include problem
> which appeared after the recent winsock header work in
> mingw-w64-headers.
This patch isn't OK, because it fixes an inclusion order problem by
moving things around without a comment. Everywhere else the
"gdb_XXX.h" headers are included in a group, last. So someone's going
to clean up these files and reintroduce the problem.
It sounds like part of the problem is the inclusion of winsock2.h in
gdb_select.h, and windows.h in serial.h. Should we include both
headers in both files to avoid the problem?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-03-26 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 10:54 Ozkan Sezer
2010-03-26 11:15 ` Kai Tietz
2010-03-26 11:20 ` Kai Tietz
2010-03-26 11:21 ` Ozkan Sezer
2010-03-26 14:17 ` Daniel Jacobowitz [this message]
2010-03-26 14:47 ` Ozkan Sezer
2010-03-26 15:24 ` Ozkan Sezer
2010-03-26 15:33 ` Daniel Jacobowitz
2010-03-26 15:35 ` Ozkan Sezer
2010-03-27 16:15 ` Ozkan Sezer
2010-03-30 18:08 ` Tom Tromey
2010-03-30 18:18 ` Ozkan Sezer
2010-03-28 18:43 ` Christopher Faylor
2010-03-28 18:48 ` Ozkan Sezer
2010-03-28 19:01 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100326141655.GA23473@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
--cc=ktietz70@googlemail.com \
--cc=sezeroz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox