From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26509 invoked by alias); 26 Mar 2010 11:40:17 -0000 Received: (qmail 26500 invoked by uid 22791); 26 Mar 2010 11:40:16 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Mar 2010 11:40:13 +0000 Received: (qmail 31300 invoked from network); 26 Mar 2010 11:40:11 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Mar 2010 11:40:11 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH/commit] Handle errors in tracepoint target agent Date: Fri, 26 Mar 2010 11:40:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: Stan Shebs References: <4BAC1426.5050003@codesourcery.com> In-Reply-To: <4BAC1426.5050003@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003261140.09071.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00880.txt.bz2 On Friday 26 March 2010 01:55:50, Stan Shebs wrote: > The error message is never NULL, I added the MI > status bit overlooked before, But now, `error_desc' is leaking in the case you xmalloc it. When you fix that leak, you'll stumble of the fact that in some cases you have this: ts->error_desc = "" while in others you have this: ts->error_desc = (char *) xmalloc (p2 - p1 + 1); How can you reliably know if you may xfree ts->error_desc that way? xfree ("") is a no go. Comparing a pointer with "" is also not good. -- Pedro Alves