Re: [patch] Fix separate-debug with non-unique section names (PR 11409)

Tom Tromey
2010-03-25T20:00:26Z

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Tom> Can we stably sort the sections by name, using the initial index as
Tom> a secondary key?

Jan> OK, attached.

Thanks... for future reference, and for anybody following along, it is
also ok to push back on questions like that if you think they are bad
ideas. Like we discussed on irc, I couldn't really tell from this reply
what you thought of it.

Jan> 2010-03-25 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> * symfile.c (build_section_addr_info_from_bfd): New.
Jan> (build_section_addr_info_from_objfile): Base it on
Jan> build_section_addr_info_from_bfd.
Jan> (addrs_section_compar, addrs_section_sort): New.
Jan> (addr_info_make_relative): New variables my_cleanup, abfd_addrs,
Jan> addrs_sorted, abfd_addrs_sorted and addrs_to_abfd_addrs. Build
Jan> addrs_to_abfd_addrs. Use it for recalculating ADDRS.

Jan> + /* SECTINDEX is underfined iff ADDR is zero. */

A small typo: s/underfined/undefined/

This patch looks good to me. It is ok.

Tom