From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4565 invoked by alias); 24 Mar 2010 20:43:00 -0000 Received: (qmail 4541 invoked by uid 22791); 24 Mar 2010 20:42:58 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Mar 2010 20:42:54 +0000 Received: (qmail 29937 invoked from network); 24 Mar 2010 20:42:53 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Mar 2010 20:42:53 -0000 Date: Wed, 24 Mar 2010 20:43:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [patch] Fix separate-debug with non-unique section names (PR 11409) Message-ID: <20100324204250.GC31992@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , Tom Tromey , gdb-patches@sourceware.org References: <20100323205655.GA12124@host0.dyn.jankratochvil.net> <20100324200943.GA12225@host0.dyn.jankratochvil.net> <20100324201825.GA31992@caradoc.them.org> <20100324203252.GA17319@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100324203252.GA17319@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00822.txt.bz2 On Wed, Mar 24, 2010 at 09:32:52PM +0100, Jan Kratochvil wrote: > > else if (section j's name is not present in separate file) > or main? > > j++, continue You're right, I meant main. Even with that in your perl script fixed, it still won't work. > .dynstr is present in both files and on different places from my real > prelinked /bin/bash example. Maybe this happened because prelink does special magic with dynamic sections to create space. I don't understand what else could have done it. I don't know how to correlate two lists of sections that are only mostly the same. I guess, you could add a fallback to the algorithm I proposed: if each file only has one section with that name, use it, and otherwise skip the section. We're really guessing at this point though! -- Daniel Jacobowitz CodeSourcery