From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71369-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11348 invoked by alias); 24 Mar 2010 19:23:34 -0000
Received: (qmail 11337 invoked by uid 22791); 24 Mar 2010 19:23:33 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Mar 2010 19:23:28 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o2OJN8pK015410; 	Wed, 24 Mar 2010 20:23:08 +0100 (CET)
Received: (from kettenis@localhost) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o2OJN6vL028899; 	Wed, 24 Mar 2010 20:23:07 +0100 (CET)
Date: Wed, 24 Mar 2010 19:23:00 -0000
Message-Id: <201003241923.o2OJN6vL028899@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: tromey@redhat.com
CC: jan.kratochvil@redhat.com, gdb-patches@sourceware.org
In-reply-to: <m339zpk0gg.fsf@fleche.redhat.com> (message from Tom Tromey on 	Wed, 24 Mar 2010 13:02:07 -0600)
Subject: Re: [patch] Fix separate-debug with non-unique section names (PR 11409)
References: <20100323205655.GA12124@host0.dyn.jankratochvil.net> <m339zpk0gg.fsf@fleche.redhat.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00814.txt.bz2

> From: Tom Tromey <tromey@redhat.com>
> Date: Wed, 24 Mar 2010 13:02:07 -0600
> 
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> gdb-7.1 is now broken for example for debugging /usr/bin/emacs due to:
> Jan> http://sourceware.org/bugzilla/show_bug.cgi?id=11409
> Jan>   [22] .data   PROGBITS 00000000007fe8a0 1fe8a0 215068 00  WA  0   0 32
> Jan>   [23] .data   PROGBITS 0000000000a13920 413920 68c6e0 00  WA  0   0 32
> 
> Jan> 2010-03-23  Jan Kratochvil  <jan.kratochvil@redhat.com>
> Jan> 	* symfile.c (addr_info_make_relative): Move sect declaration to the
> Jan> 	outer block.  Initialize it to NULL.  Prefer SECT->next more than
> Jan> 	bfd_get_section_by_name.
> 
> This patch seems to assume that all sections of the same name will be
> next to each other in the section_addr_info.  Why is it ok to make this
> assumption?

That assumption is false, at least in general.  I have an
OpenBSD/mips64el emacs binary that has two .data sections that aren't
adjacent.