From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18064 invoked by alias); 19 Mar 2010 01:26:28 -0000 Received: (qmail 18055 invoked by uid 22791); 19 Mar 2010 01:26:28 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 19 Mar 2010 01:26:24 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 862811B4028; Fri, 19 Mar 2010 01:26:22 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [PATCH 02/16] gdb: tests: add support for testing FLAT toolchains Date: Fri, 19 Mar 2010 01:26:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.33; KDE/4.4.1; x86_64; ; ) Cc: Daniel Jacobowitz References: <1268896240-4188-1-git-send-email-vapier@gentoo.org> <20100318133817.GA8131@caradoc.them.org> In-Reply-To: <20100318133817.GA8131@caradoc.them.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6104827.y40HLeDi0C"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201003182126.17119.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00712.txt.bz2 --nextPart6104827.y40HLeDi0C Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1553 On Thursday 18 March 2010 09:38:22 Daniel Jacobowitz wrote: > On Thu, Mar 18, 2010 at 03:10:40AM -0400, Mike Frysinger wrote: > > FLAT toolchains output a FLAT binary for the named output and create > > another file with a .gdb suffix that is used for debugging. So when > > testing a FLAT toolchain and we need to load up a file, use the .gdb. >=20 > FWIW, in our board files, we found it simpler to swap the two. So > we have a gdb_compile which generates an elf file as foo, and a flat > file as foo.flt. Nothing in the GDB testsuite except for the board > file itself needs to access the FLT file. hmm, that is one way of going about the issue, but personally i feel that t= his=20 kind of logic should be in the test suite. imo, the dejagnu framework alre= ady=20 puts too much demand on the end user to simply run `make check`. plus, sin= ce=20 this isnt specific to an arch and FLAT isnt an uncommon target, doing it on= ce=20 in common code seems like it'd be easier for people to collaborate on. > That's not the only way to do it, we can accomodate both. But I'm not > thrilled with having binfmt_flat references scattered around random > tests. In lib/ maybe, but not everywhere that uses gdb_file_cmd... >=20 > Or in the main definition of gdb_compile? i agree the current patch isnt terrible suave, but i'm not terribly familia= r=20 with the gdb testing framework. so i thought i'd post the patch to garner= =20 feedback on a better way and then attack the problem based on that. i'll give gdb_compile a try ... thanks ! -mike --nextPart6104827.y40HLeDi0C Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLotK5AAoJEEFjO5/oN/WBUioQAJIreXpE2pxB7VwRHw4geeLV lJQVdOnvlOfUR4Cwd0r4TEHahNvGs0dCJnzi0YukM4DyfRxEeVD/w79Hj3cHeUlv xaV5g8eJwh1x/pg+pw+KbYZhSM8WVuqdoJxpmJhMmuXBNVb9ngLwtILCMIGVVnMa ZnhiDnuBvDwcc5qz9YouPOrhIdzTnwb5h6KNpPiRYYt/2D06xXybfFOQMKLriT+7 olg/MkOEkqiZKy1c1B9byIyVTyQEDBjIx4LSc+12eF5dqKkj/C0UxwS5TmJI0n+F EvJnaTmcEdfbP9vhpCwuJGrqhyQt94pJI49LB+8upobExuCjL105QT/50WpJDb8c VBGdC4x2IZYtmFMAGwxxSXV0NrKbBeMhsLmawlyCntQKu2qvUPVAtiFXtNe5+tGO 4pPQCv4csiQO+0dOVjMb5PadzQV0vKa/hOqAvh07Y/Nk8iDb4TBghWdzEaFJ44y2 McN1MWKcY8/q3qQWy7hzuvOsGpXEZ4np7AR9TmN2rVRmCVBQZR5DlxhpOU05VumG LycJ27AFDvE57EnkSewY4jpoRfhDDjFsRD53IXSuVNKv+Vi3Y8IklFIteswsRmTZ tHRKZ1zuxZZFOZPJBjFUz5egzaB4fqJi6195qLSsBA7GFJQvamsyHyquvpaMKfw7 LGQaISBdxNZqZoz/VrDC =Xy9E -----END PGP SIGNATURE----- --nextPart6104827.y40HLeDi0C--