From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5552 invoked by alias); 18 Mar 2010 18:58:30 -0000 Received: (qmail 5543 invoked by uid 22791); 18 Mar 2010 18:58:30 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Mar 2010 18:58:27 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o2IItidi020883; Thu, 18 Mar 2010 19:55:44 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o2IIthRb027235; Thu, 18 Mar 2010 19:55:43 +0100 (CET) Date: Thu, 18 Mar 2010 18:58:00 -0000 Message-Id: <201003181855.o2IIthRb027235@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: dje@google.com CC: pedro@codesourcery.com, gdb-patches@sourceware.org In-reply-to: (message from Doug Evans on Thu, 18 Mar 2010 11:23:38 -0700) Subject: Re: [RFC] Why does ui_out_field_core_addr pad with leading zeroes? References: <20100318173015.6765784413@ruffy.mtv.corp.google.com> <201003181747.29518.pedro@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00683.txt.bz2 > Date: Thu, 18 Mar 2010 11:23:38 -0700 > From: Doug Evans > > > It also aids visual alignment I suppose.  Try also adding > > a breakpoint in a shared library in your example, > > and redoing `info break'. The column is presently > > aligned left.  I suspect it won't look as neat after > > your patch. > > I realize that *could* happen, but since we're doing this fancy ui-out > thing, I would expect it's the job of the front end to do any desired > alignment. > > For reference sake, this is what I get with my patch: > > (gdb) b main > Breakpoint 2 at 0x40049c: file hello.c, line 6. > (gdb) i b > Num Type Disp Enb Address What > 2 breakpoint keep y 0x40049c in main at hello.c:6 > (gdb) b printf > Breakpoint 3 at 0x7ffff7acbe40 > (gdb) i b > Num Type Disp Enb Address What > 2 breakpoint keep y 0x40049c in main at hello.c:6 > 3 breakpoint keep y 0x7ffff7acbe40 > (gdb) So since the CLI obviously doesn't align the unpadded addresses properly, I'd say your diff shouldn't go in until it does. Cheers, Mark