> Date: Thu, 18 Mar 2010 11:23:38 -0700 > From: Doug Evans > > > It also aids visual alignment I suppose.  Try also adding > > a breakpoint in a shared library in your example, > > and redoing `info break'. The column is presently > > aligned left.  I suspect it won't look as neat after > > your patch. > > I realize that *could* happen, but since we're doing this fancy ui-out > thing, I would expect it's the job of the front end to do any desired > alignment. > > For reference sake, this is what I get with my patch: > > (gdb) b main > Breakpoint 2 at 0x40049c: file hello.c, line 6. > (gdb) i b > Num Type Disp Enb Address What > 2 breakpoint keep y 0x40049c in main at hello.c:6 > (gdb) b printf > Breakpoint 3 at 0x7ffff7acbe40 > (gdb) i b > Num Type Disp Enb Address What > 2 breakpoint keep y 0x40049c in main at hello.c:6 > 3 breakpoint keep y 0x7ffff7acbe40 > (gdb) So since the CLI obviously doesn't align the unpadded addresses properly, I'd say your diff shouldn't go in until it does. Cheers, Mark