From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24738 invoked by alias); 18 Mar 2010 18:39:14 -0000 Received: (qmail 24730 invoked by uid 22791); 18 Mar 2010 18:39:13 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Mar 2010 18:39:02 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 33E202BAB8C; Thu, 18 Mar 2010 14:39:01 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GDd6JoClIr0r; Thu, 18 Mar 2010 14:39:01 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F04302BAB4A; Thu, 18 Mar 2010 14:39:00 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 999E7F5917; Thu, 18 Mar 2010 11:38:58 -0700 (PDT) Date: Thu, 18 Mar 2010 18:39:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA/dwarf] Anonymous nested function causes SEGV during psymbol read Message-ID: <20100318183858.GC2844@adacore.com> References: <1266519724-4175-1-git-send-email-brobecker@adacore.com> <20100316211903.GE3830@adacore.com> <20100317162248.GG3830@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00681.txt.bz2 > Joel> Yet another version: Instead of generating the complaint while creating > Joel> the psymbols, I decided to generate them during the symtab creation > Joel> phase. A couple of reasons: > [...] > Joel> That's why I like this version better... > > FWIW, seems reasonable to me. Thanks! Checked in (I just lOoove that git cvsexportcommit thing :). The only thing is the length of the commit messages. They now contain the full description of the issue this patch is fixing, very close to the initial email I send when submitting a patch. Is that a problem with anyone? -- Joel