From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10082 invoked by alias); 18 Mar 2010 07:43:44 -0000 Received: (qmail 10067 invoked by uid 22791); 18 Mar 2010 07:43:43 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Mar 2010 07:43:39 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id DD8E71B40B3; Thu, 18 Mar 2010 07:43:36 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [patch] break-interp.exp: handle /usr/sbin/prelink.bin Date: Thu, 18 Mar 2010 07:43:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.33; KDE/4.4.1; x86_64; ; ) Cc: Doug Evans References: <20100318061507.102F084414@ruffy.mtv.corp.google.com> <201003180315.31166.vapier@gentoo.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1320333.KO57415lPv"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201003180343.34183.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00654.txt.bz2 --nextPart1320333.KO57415lPv Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1150 On Thursday 18 March 2010 03:26:20 Doug Evans wrote: > On Thu, Mar 18, 2010 at 12:15 AM, Mike Frysinger wrot= e: > > On Thursday 18 March 2010 02:15:07 Doug Evans wrote: > >> - if {$result =3D=3D 1 && [regexp {^(/usr/sbin/prelink: [^ ]* does = not > >> have .gnu.prelink_undo section\n?)*$} $output]} { > >> + if {$result =3D=3D 1 && [regexp {^(/usr/sbin/prelink[^ ]*: [^ ]* = does > >> not have .gnu.prelink_undo section\n?)*$} $output]} { > >=20 > > since the prelink filename shouldnt have a colon in it, should that be > > used in the regex instead ? > > /usr/sbin/prelink[^:]*: >=20 > Either is arguably wrong IMO. Why can't the program have a colon or > space in its name? i said "shouldnt", not "cant". i was thinking from a practical standpoint = --=20 spaces are much more common than colons in filenames, and colons are genera= lly=20 discouraged from paths because they break fundamental things like colon- separated variables such as $PATH. > But I don't have a strong opinion on which one to actually use, or > something else. just a suggestion; i dont particularly care as i dont deal with prelink. -mike --nextPart1320333.KO57415lPv Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAABAgAGBQJLodmmAAoJEEFjO5/oN/WBF30QAL4ulKf1RFv2ERz+5HXyZ12w tlE9gPRN7T5ETXDk68kIYo45xl2PfOMgBlqg8mqGStMZ+gcLiOtAj1hE4ke5GwzE iKAhZXg3vZ9ZmWzSGKwc/RCsQeaUmphk0xJ7Oqzbs1+8+i1mJZJIyps5RQv1ieXU e5TRaL0zbbaQUA5JG9/SdORoEtcf1BOJy+F7B+zQEbGv9QXWyXWS5Fc8WmRWGP6r ftK/Zk2iaOEfV3xRt0uX5jmfbxIXdFMi07MWb00XeDf/8ZvmvOb78bm7zBsL4ljT uBtAIvIGsQTb09sjF7x5rAs3iKjb/jMwRP5VLtJMWYyJVphKHTyNXwezrainX9FC KiH1kcnDMb3KYo0g3zpWRMmO2sf5AcW+2dHSO8UwLMf4n2aAs2iz3fuEpAnn/PmV 86ygFlBNncgnceG+CeR4osKB9xdwtky5qZxatn4ZeUmpCxlI/8m6qFT1DOtWYxnc ZUqQxO1gq4t97JNPTT96Dg2ZrakW8nSdAUx1u1ufZL46dLdojokQpQtbHWjOlPh9 jpWVDaI0yuwChlgoN7uX9TGrHnjNLHCbaSs+svY8piHsyKW3FRCHsFAStUDqxyCj BwRkZMHyd7Ho84CQ/7Tr0qfacTbXMROvm2Do6VuNwE+Mvl7DgsGS48wCiN4rdGWp DZPdw0yFf66Hut4lTxtL =S6ER -----END PGP SIGNATURE----- --nextPart1320333.KO57415lPv--