From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71134-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20367 invoked by alias); 16 Mar 2010 13:23:04 -0000
Received: (qmail 20359 invoked by uid 22791); 16 Mar 2010 13:23:04 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Mar 2010 13:22:58 +0000
Received: (qmail 11214 invoked from network); 16 Mar 2010 13:22:56 -0000
Received: from unknown (HELO wind.localnet) (vladimir@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 16 Mar 2010 13:22:56 -0000
From: Vladimir Prus <vladimir@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Subject: Re: [MI tracepoints 7/9] -trace-find
Date: Tue, 16 Mar 2010 13:23:00 -0000
User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic-pae; KDE/4.3.2; i686; ; )
Cc: gdb-patches@sourceware.org
References: <201003141159.44482.vladimir@codesourcery.com> <201003160027.53945.pedro@codesourcery.com>
In-Reply-To: <201003160027.53945.pedro@codesourcery.com>
MIME-Version: 1.0
Content-Type: Text/Plain;   charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201003161622.55119.vladimir@codesourcery.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00579.txt.bz2

On Tuesday 16 March 2010 03:27:53 Pedro Alves wrote:

> I stopped a few minor issues.
> 
> On Sunday 14 March 2010 08:59:44, Vladimir Prus wrote:
> > +    error ("May not look at trace frames while trace is running.");
> 
> Missing i18n.
> 
> > +  else if (strcmp (mode, "tracepoint-number") == 0)
> > +    {
> > +      if (argc != 2)
> > +       error (_("frame number is required"));
> > +      tfind_1 (tfind_tp, atoi (argv[1]), 0, 0, 0);
> > +    }
> 
> You mean, "tracepoint number is required".
> 
> On Sunday 14 March 2010 08:59:44, Vladimir Prus wrote:
> > -      TPP.  */
> > +      TPP.  If no trace frame matches, return -1. ay throw if the
>                                                    ^^^
> 
> "-1.  May throw"
> 
> 

Thanks for the review. I've fixed those issues locally.

-- 
Vladimir Prus
CodeSourcery
vladimir@codesourcery.com
(650) 331-3385 x722