From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30555 invoked by alias); 16 Mar 2010 16:06:41 -0000 Received: (qmail 30407 invoked by uid 22791); 16 Mar 2010 16:06:40 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Mar 2010 16:06:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DEA022BAB43; Tue, 16 Mar 2010 12:06:34 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ls8oY4cilYGQ; Tue, 16 Mar 2010 12:06:34 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B03E62BAB31; Tue, 16 Mar 2010 12:06:34 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A72BFF5917; Tue, 16 Mar 2010 09:06:32 -0700 (PDT) Date: Tue, 16 Mar 2010 16:06:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] sim: avoid TRACE redefine warnings Message-ID: <20100316160632.GC3830@adacore.com> References: <1268599156-23584-1-git-send-email-vapier@gentoo.org> <1268678817-11407-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1268678817-11407-1-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00591.txt.bz2 > 2010-03-15 Mike Frysinger > > * hw-ports.c (TRACE): Delete. > * hw-properties.c (TRACE): Delete. > (hw_find_ihandle_runtime_property): Change TRACE to HW_TRACE. > (hw_find_integer_property): Likewise. > (hw_find_integer_array_property): Likewise. > (hw_add_duplicate_property): Likewise. This looks good to me. I don't understand why people use two parentheses in the call to HW_TRACE: HW_TRACE ((me, [...], property)) But it looks like it's the style being used, so OK. -- Joel