From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, Chandru <chandru@in.ibm.com>,
gdb-patches@sourceware.org
Subject: Re: gdb can't print array element for fortran
Date: Tue, 16 Mar 2010 15:16:00 -0000 [thread overview]
Message-ID: <20100316151621.GB3830@adacore.com> (raw)
In-Reply-To: <20100315234543.GA25216@host0.dyn.jankratochvil.net>
> 2010-03-16 Jan Kratochvil <jan.kratochvil@redhat.com>
> Chandru <chandru@in.ibm.com>
>
> * dwarf2read.c (read_subrange_type): Set TYPE_HIGH_BOUND_UNDEFINED.
> * valarith.c (value_subscripted_rvalue): Suppress error if
> TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED.
This seems like a reasonable workaround, especially since we already
have some special handling of attr->form == DW_FORM_block1 for range
types. So I guess we never have block2/block4 or even block attributes
for the upper bound in practice?
Just one request:
> range_type = create_range_type (NULL, base_type, low, high);
>
> + if (attr && attr->form == DW_FORM_block1)
> + TYPE_HIGH_BOUND_UNDEFINED (range_type) = 1;
Can you add a quick comment, with a FIXME to show that this is temporary?
There's already some useful comments just slightly earlier in the code,
perhaps we just ought to refer to that, somehow.
Pre-approved with the addition of the comment.
--
Joel
next prev parent reply other threads:[~2010-03-16 15:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-12 13:06 Chandru
2010-03-15 17:13 ` Joel Brobecker
2010-03-15 20:52 ` Tom Tromey
2010-03-15 23:46 ` Jan Kratochvil
2010-03-16 15:16 ` Joel Brobecker [this message]
2010-03-16 21:04 ` Jan Kratochvil
2010-03-18 11:24 Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100316151621.GB3830@adacore.com \
--to=brobecker@adacore.com \
--cc=chandru@in.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox