On Monday 15 March 2010 21:46:05 Pedro Alves wrote:

> Double space after period everywhere please.
> 
> +  ui_out_field_int (uiout, "buffer-size",  (int) ts->buffer_size);
> +  ui_out_field_int (uiout, "buffer-free",  (int) ts->buffer_free);
> 
> When these optional fields aren't reported by the target, this
> will print -1.  I don't see that mentioned in the manual.  Is
> this intended?  I would have expected optional fields to just
> not be present, as is common in MI.  trace_status_command does
> that too.

I did not realize they are optional. Attached is the revised patch,
that I'll commit when prior patches are ready.

Thanks,

-- 
Vladimir Prus
CodeSourcery
vladimir@codesourcery.com
(650) 331-3385 x722