From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9808 invoked by alias); 16 Mar 2010 00:10:43 -0000 Received: (qmail 9796 invoked by uid 22791); 16 Mar 2010 00:10:42 -0000 X-Spam-Check-By: sourceware.org Received: from pool-96-252-118-25.bstnma.fios.verizon.net (HELO cgf.cx) (96.252.118.25) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Tue, 16 Mar 2010 00:10:37 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id 107EA13C061; Mon, 15 Mar 2010 20:10:36 -0400 (EDT) Received: by ednor.cgf.cx (Postfix, from userid 201) id 098E02B352; Mon, 15 Mar 2010 20:10:36 -0400 (EDT) Date: Tue, 16 Mar 2010 00:10:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org, Pierre Muller Subject: Re: [RFC-v4] Add windows OS Thread Information Block Message-ID: <20100316001035.GA9611@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org, Pierre Muller References: <000901c9f5ef$4ee06f10$eca14d30$@u-strasbg.fr> <201003101725.48298.pedro@codesourcery.com> <000c01cac0a0$3935fbe0$aba1f3a0$@muller@ics-cnrs.unistra.fr> <201003110000.31184.pedro@codesourcery.com> <002101cac0f2$a2298890$e67c99b0$@muller@ics-cnrs.unistra.fr> <000e01cac488$27dcf970$7796ec50$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000e01cac488$27dcf970$7796ec50$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00568.txt.bz2 On Mon, Mar 15, 2010 at 10:40:38PM +0100, Pierre Muller wrote: > This is a new version of my patch to add support for >displaying thread-information-block for Windows OS >inferior programs. > > I tried to follow several advices I got earlier and made several >changes. > The most important one concerns the remote/gdbserver communication: >instead of using TARGET_OBJECT_DATA, I defined a new target_ops method >called to_get_tib_address and defined a new query packet >PACKET_qGetTIBAddr adapted from the existing PACKET_qGetTLSAddr. > > I also tried to write a first draft of the documentation >patch and hope for some input from Eli on this matter... > > There are only minor changes in the windows-nat and windows-tdep files, >the main one being the adaptation to the new to_get_tib_addr >field of the target_ops struct. > > I hope this new version will be closer to the expectation >of most of you and look forward to hearing your comments. > > >Pierre > >PS: After checking, I indeed change the order of >active_rpc_handle and thead_local_storage fields in You call this "thead" rather than "thread" in a couple of places. Other than that it looks ok, assuming that others concerns have been addressed. Thanks. cgf