Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: FYI: fix PR 9708
Date: Mon, 15 Mar 2010 20:11:00 -0000	[thread overview]
Message-ID: <20100315201121.GA7450@caradoc.them.org> (raw)
In-Reply-To: <m3ocipe4ok.fsf@fleche.redhat.com>

On Mon, Mar 15, 2010 at 02:00:11PM -0600, Tom Tromey wrote:
> Yes, I think we should also omit DW_TAG_subprogram here.  I just didn't
> think of it.  I can either just check it in, or if you have an easy way
> to test it, let me know.  I've appended the patch.

The patch looks good to me; would you mind committing it?

I'm flushing out a bunch of fixed for the C parts of the GDB testsuite
with RealView; in a week or so, I think I'll be ready to start
seriously working on the C++ parts.  At that point I can be less
hypothetical.

> Calling them f()::x might be interesting, but there are some caveats.

The only reason I thought of this was:

drow@caradoc:~% cat a.c
int f()
{
  static int x;
  return x;
}
drow@caradoc:~% nm a.o | c++filt
0000000000000000 T f()
0000000000000000 b f()::x
                 U __gxx_personality_v0

i.e. that's what the physname would be if we demangled the linkage
name.

Other than that, I'm not attached to it.

> opsy. nm pr | grep themagicstatic
> 080497de V _ZZN1K1mEvE14themagicstatic
> 080497dd V _ZZN1K1mEvE14themagicstatic_0

For added amusement pipe that to c++filt.  They demangle the same.
Doesn't that seem like a bug?

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2010-03-15 20:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-13  0:25 Tom Tromey
2010-03-13  2:36 ` Daniel Jacobowitz
2010-03-15 20:00   ` Tom Tromey
2010-03-15 20:11     ` Daniel Jacobowitz [this message]
2010-03-15 20:25       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100315201121.GA7450@caradoc.them.org \
    --to=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox