Re: [Patch] Exit gdb/configure.tgt for unsupported targets

Ralf Corsepius
2010-02-25T05:40:51Z

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

On 02/24/2010 06:00 PM, Ralf Corsepius wrote:
> On 02/24/2010 05:51 PM, Tom Tromey wrote:
>>>>>>> "Ralf" == Ralf Corsepius<ralf.corsepius@rtems.org> writes:
>> Ralf> 2010-02-23 Ralf CorsÃ©pius<ralf.corsepius@rtems.org>
>> Ralf> * configure.tgt: Exit if ${gdb_target_obs}" is not set.
>>
>> Ralf> +if test -z "${gdb_target_obs}"; then
>> Ralf> + echo "*** Configuration ${targ} is unsupported.">&2
>> Ralf> + exit 1
>> Ralf> +fi
>>
>> I think it would be better to do the test in configure.ac and use
>> AC_MSG_ERROR.
> I wasn't aware "${gdb_target_obs}" is exported to configure.ac and
> intended to keep configure.tgt self-contained ;)
>
> Now that it apparently is exported and used in configure.ac, I agree
> with you, configure.ac+AC_MSG_ERROR would be better.

Reworked patch enclosed below.

Ralf

[-- Attachment #2: gdb-7.0.90-gdb-configure.diff --]
[-- Type: text/plain, Size: 1176 bytes --]

2010-02-25 Ralf CorsÃ©pius <ralf.corsepius@rtems.org>

* configure.ac: Exit if ${gdb_target_obs}" is not set.
* configure: Regenerate.

diff -Naur gdb-7.0.90.orig/gdb/configure gdb-7.0.90-rtems4.10-20100225/gdb/configure
--- gdb-7.0.90.orig/gdb/configure 2010-02-19 01:23:00.000000000 +0100
+++ gdb-7.0.90-rtems4.10-20100225/gdb/configure 2010-02-25 05:25:54.000000000 +0100
@@ -6927,6 +6927,10 @@

. ${srcdir}/configure.tgt

+ if test -z "${gdb_target_obs}"; then :
+ as_fn_error "configuration ${targ} is unsupported." "$LINENO" 5
+fi
+
# Target-specific object files
for i in ${gdb_target_obs}; do
case " $TARGET_OBS " in
diff -Naur gdb-7.0.90.orig/gdb/configure.ac gdb-7.0.90-rtems4.10-20100225/gdb/configure.ac
--- gdb-7.0.90.orig/gdb/configure.ac 2010-02-19 01:23:00.000000000 +0100
+++ gdb-7.0.90-rtems4.10-20100225/gdb/configure.ac 2010-02-25 05:25:48.000000000 +0100
@@ -161,6 +161,9 @@

. ${srcdir}/configure.tgt

+ AS_IF([test -z "${gdb_target_obs}"],
+ [AC_MSG_ERROR([configuration ${targ} is unsupported.])])
+
# Target-specific object files
for i in ${gdb_target_obs}; do
case " $TARGET_OBS " in