Re: [PATCH] sim: avoid TRACE redefine warnings

Joel Brobecker
2010-03-15T16:49:44Z

> as i mentioned in the first e-mail, "TRACE" is defined on the command
> line, so any macro named "TRACE" has to be renamed.

I understood why you had to rename the macro. The problem is that
I'm wondering what this macro is supposed to be used for. It's important
because I suspect the change that you made might be incorrect, depending
on the answer to the question above. For instance, I suspect that the
use of the TRACE macro in that file might be related to
--enable-sim-traces, and thus renaming TRACE to something else will break
that.

That's why, IMO, we need to:
- Understand how --enable-sim-traces work to see if it is related
to the use of this TRACE macro;
- Find out how to properly fix your problem;

If you want, I can try doing some digging, but I think it's going to be
a while before I can get to it, which is why I'm giving you as much info
as I have (I really do not have much sim experience, but apparently we
are short in reviewers for the sim code).

--
Joel