From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6948 invoked by alias); 15 Mar 2010 16:49:44 -0000 Received: (qmail 6933 invoked by uid 22791); 15 Mar 2010 16:49:43 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 15 Mar 2010 16:49:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D3D732BAB57; Mon, 15 Mar 2010 12:49:37 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id U+Nx+qN3HX4I; Mon, 15 Mar 2010 12:49:37 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A0D692BAB56; Mon, 15 Mar 2010 12:49:37 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E1543F5917; Mon, 15 Mar 2010 09:49:34 -0700 (PDT) Date: Mon, 15 Mar 2010 16:49:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: avoid TRACE redefine warnings Message-ID: <20100315164934.GK3045@adacore.com> References: <1268599156-23584-1-git-send-email-vapier@gentoo.org> <20100315003538.GB3045@adacore.com> <201003150317.58516.vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201003150317.58516.vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00542.txt.bz2 > as i mentioned in the first e-mail, "TRACE" is defined on the command > line, so any macro named "TRACE" has to be renamed. I understood why you had to rename the macro. The problem is that I'm wondering what this macro is supposed to be used for. It's important because I suspect the change that you made might be incorrect, depending on the answer to the question above. For instance, I suspect that the use of the TRACE macro in that file might be related to --enable-sim-traces, and thus renaming TRACE to something else will break that. That's why, IMO, we need to: - Understand how --enable-sim-traces work to see if it is related to the use of this TRACE macro; - Find out how to properly fix your problem; If you want, I can try doing some digging, but I think it's going to be a while before I can get to it, which is why I'm giving you as much info as I have (I really do not have much sim experience, but apparently we are short in reviewers for the sim code). -- Joel