From: Mike Frysinger <vapier@gentoo.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: avoid TRACE redefine warnings
Date: Mon, 15 Mar 2010 07:18:00 -0000 [thread overview]
Message-ID: <201003150317.58516.vapier@gentoo.org> (raw)
In-Reply-To: <20100315003538.GB3045@adacore.com>
[-- Attachment #1: Type: Text/Plain, Size: 667 bytes --]
On Sunday 14 March 2010 20:35:38 Joel Brobecker wrote:
> > 2010-03-14 Mike Frysinger <vapier@gentoo.org>
> >
> > * hw-ports.c (TRACE): Delete.
> > * hw-properties.c (TRACE): Rename to _TRACE.
>
> The change in hw-ports.c is OK, but I don't get the change in
>
> hw-properties.c:
> > -#define TRACE(A,B)
> > +#define _TRACE(A,B)
>
> Can you explain?
as i mentioned in the first e-mail, "TRACE" is defined on the command line, so
any macro named "TRACE" has to be renamed. since this file actually used the
macro, i renamed them all. i could simply delete all TRACE usage in the file
if you prefer ... doesnt really matter to me.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-03-15 7:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-14 20:37 Mike Frysinger
2010-03-15 0:35 ` Joel Brobecker
2010-03-15 7:18 ` Mike Frysinger [this message]
2010-03-15 16:49 ` Joel Brobecker
2010-03-15 18:35 ` Mike Frysinger
2010-03-15 0:43 ` Pedro Alves
2010-03-15 7:18 ` Mike Frysinger
2010-03-15 10:53 ` Matt Rice
2010-03-15 13:03 ` Pedro Alves
2010-03-15 18:47 ` [PATCH v2] " Mike Frysinger
2010-03-16 16:06 ` Joel Brobecker
2010-03-22 22:56 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003150317.58516.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox