Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [RFA] lengthen timeouts in gdb.base/checkpoint.exp
Date: Wed, 10 Mar 2010 23:53:00 -0000	[thread overview]
Message-ID: <20100310235324.7B3288439C@ruffy.mtv.corp.google.com> (raw)

Hi.

I'm seeing timeout failures in gdb.base/checkpoint.exp
on the 7.1 branch.

Running ../../../../src/gdb/testsuite/gdb.base/checkpoint.exp ...
FAIL: gdb.base/checkpoint.exp: break2 with many checkpoints (timeout)
FAIL: gdb.base/checkpoint.exp: info checkpoints with at least 600 checkpoints (timeout)
FAIL: gdb.base/checkpoint.exp: kill all one (timeout)

Ok to apply to trunk and 7.1 branch?

I went with adding a number to the existing timeout value because
I didn't want to make any assumptions on what the existing timeout
value was (I can imagine wanting to globally increase the timeout
to some value when testing a slow serial target).
I cut-n-pasted the means to save/restore timeout from watchpoint.exp.

2010-03-10  Doug Evans  <dje@google.com>

	* gdb.base/checkpoint.exp: Fix comment.
	Lengthen timeout while doing >600 checkpoints test.
	Rename duplicate "kill all one" test to keep test names unique.

Index: checkpoint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/checkpoint.exp,v
retrieving revision 1.11
diff -u -p -r1.11 checkpoint.exp
--- checkpoint.exp	1 Jan 2010 07:32:00 -0000	1.11
+++ checkpoint.exp	10 Mar 2010 23:46:20 -0000
@@ -328,7 +328,7 @@ gdb_test "restart 9" "Not found.*" "no m
 gdb_test "restart 10" "Not found.*" "no more checkpoint 10"
 
 #
-# Now let's try setting a large number of checkpoints (>1000)
+# Now let's try setting a large number of checkpoints (>600)
 #
 
 gdb_exit
@@ -352,6 +352,10 @@ gdb_expect {
     timeout { fail "(timeout) set checkpoint breakpoint" }
 }
 
+set prev_timeout $timeout
+set timeout [expr $timeout + 120]
+verbose "Timeout now $timeout sec."
+
 gdb_breakpoint $break2_loc
 gdb_test "continue" "breakpoint 2.*" "break2 with many checkpoints"
 
@@ -375,9 +379,13 @@ gdb_test_multiple "info checkpoints" $ms
 # OK, kill 'em all...
 #
 
-gdb_test "kill" "" "kill all one" \
+gdb_test "kill" "" "kill all one with many checkpoints" \
     "Kill the program being debugged.*y or n. $" "y"
 
+# Restore old timeout
+set timeout $prev_timeout
+verbose "Timeout now $timeout sec."
+
 #
 # Finished: cleanup
 #


             reply	other threads:[~2010-03-10 23:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-10 23:53 Doug Evans [this message]
2010-03-11  0:11 ` Daniel Jacobowitz
2010-03-11  0:11 ` Michael Snyder
2010-03-11  0:15   ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100310235324.7B3288439C@ruffy.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox