From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5880 invoked by alias); 10 Mar 2010 21:30:08 -0000 Received: (qmail 5864 invoked by uid 22791); 10 Mar 2010 21:30:05 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Mar 2010 21:30:02 +0000 Received: (qmail 12494 invoked from network); 10 Mar 2010 21:30:00 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Mar 2010 21:30:00 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] gdbserver, errno handling in my_waitpid Date: Wed, 10 Mar 2010 21:30:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; ) Cc: Michael Snyder , Doug Evans , dan@codesourcery.com References: <4B980E29.5090208@vmware.com> In-Reply-To: <4B980E29.5090208@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003102129.58617.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00397.txt.bz2 On Wednesday 10 March 2010 21:24:57, Michael Snyder wrote: > This is not really my most familiar bit of the code, so > you gdbserver guys check me, ok? > > It seems to me that we need to set errno to zero before calling waitpid, > if we're going to check it right after. Especially the second time. I don't think do; we only check it if waitpid returns -1, and in that case, waitpid should have changed errno itself. Or have you found an actual problem here? -- Pedro Alves