From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28511 invoked by alias); 11 Mar 2010 03:48:12 -0000 Received: (qmail 28503 invoked by uid 22791); 11 Mar 2010 03:48:11 -0000 X-SWARE-Spam-Status: No, hits=-8.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Mar 2010 03:48:04 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2B3m3uZ009324 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 10 Mar 2010 22:48:03 -0500 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2B3m2YE026251 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Wed, 10 Mar 2010 22:48:02 -0500 Date: Thu, 11 Mar 2010 03:48:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [RFC] remote-mips.c: Make sure that each function has an introductory comment Message-ID: <20100310204802.04b3c05e@redhat.com> In-Reply-To: <20100309223707.4ea02d43@redhat.com> References: <20100308151822.2adfab51@redhat.com> <83lje12xma.fsf@gnu.org> <20100309223707.4ea02d43@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00410.txt.bz2 On Tue, 9 Mar 2010 22:37:07 -0700 Kevin Buettner wrote: > * remote-mips.c (close_ports, mips_initialize_cleanups) > (mips_exit_cleanups, mips_send_command, mips_open, pmon_open) > (ddb_open, lsi_open, mips_remove_breakpoint, mips_remove_watchpoint) > (mips_stopped_by_watchpoint, send_srec, pmon_checkset) > (pmon_make_fastrec, pmon_check_ack, mips_expect_download) > (pmon_check_entry_address, pmon_check_total, pmon_end_download) > (pmon_download, pmon_load_fast, _initialize_remote_mips): Add > comments describing each of these functions. > (mips_enter_debug, mips_exit_debug, common_open) > (mips_signal_from_protocol, pmon_makeb64, pmon_zeroset): Add > blank line after the comment describing the function. Committed. Thanks to Joel and Eli for the reviews. Kevin