From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17150 invoked by alias); 10 Mar 2010 13:27:13 -0000 Received: (qmail 17140 invoked by uid 22791); 10 Mar 2010 13:27:12 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Mar 2010 13:27:08 +0000 Received: (qmail 6593 invoked from network); 10 Mar 2010 13:27:07 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 Mar 2010 13:27:07 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: Somewhat sanitize watchpoints with conditions on local expressions Date: Wed, 10 Mar 2010 13:27:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; ) References: <201003040350.34417.pedro@codesourcery.com> <201003041612.17294.pedro@codesourcery.com> <201003041618.59734.pedro@codesourcery.com> In-Reply-To: <201003041618.59734.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201003101327.04927.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00383.txt.bz2 On Thursday 04 March 2010 16:18:59, Pedro Alves wrote: > gdb/ > * breakpoint.c (condition_command): Handle watchpoint conditions. > (is_hardware_watchpoint): Add comment. > (is_watchpoint): New. > (update_watchpoint): Don't reparse the watchpoint's condition > unless necessary. > (WP_IGNORE): New. > (watchpoint_check): Use it. > (bpstat_check_watchpoint): Handle it. > (bpstat_check_breakpoint_conditions): Evaluate watchpoint local > conditions in a frame where it makes sense. > (watch_command_1): Store the innermost block of the condition > expression. > (delete_breakpoint): Delete the watchpoint condition expression. > * breakpoint.h (struct bp_location) : Update comment. > (struct breakpoint): New field `cond_exp_valid_block'. > > gdb/testsuite/ > * gdb.base/watch-cond.c, gdb.base/watch-cond.exp: New. I've committed these now. -- Pedro Alves