Re: [RFA] Fix remote-fileio.c compilation for Cygwin 1.5 API

Christopher Faylor
2010-03-09T19:15:18Z

On Tue, Mar 09, 2010 at 12:21:05AM +0100, Pierre Muller wrote:
>> >> I do not really know if there is a specific maintainer for this
>> >> file... Could someone (a global maintainr?)
>> >> please review this patch?
>> >
>> >This is OK.
>>
>> Sorry, I guess I was wrong about the opinion. I do have a mild one.
>>
>> While I said I didn't have an opinion about this, wouldn't it really
>> make sense to use the same mechanism that I adopted for windows-nat.c?
>
>The problem is that this macro does not check the value of the first
>argument, which makes me fear that if someone reuses
>cygwin_conv_path function elsewhere inside remote-fileio.c source
>we might get into the same troubles as the ones
>I just discovered for windows-nat.c
>
>See http://sourceware.org/ml/gdb-patches/2010-03/msg00344.html

You're right. My macro was too simple minded. I've checked in your
change to windows-nat.c. If you want to use that in remote-fileio.c
that's fine. Or not. It really isn't a big deal either way.

cgf