From: Joel Brobecker <brobecker@adacore.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] remote-mips.c: Add support for NEC rockhopper boards
Date: Tue, 09 Mar 2010 04:52:00 -0000 [thread overview]
Message-ID: <20100309045227.GL3081@adacore.com> (raw)
In-Reply-To: <20100308121028.006c65ae@redhat.com>
> I noticed that several of the other _open functions are missing
> comments describing what they do also. I was tempted to add those
> comments to this patch too, but decided against it since that would go
> beyond the intended scope of this patch.
Definitely agreed. It's great that you're willing to improve the situation
in this case, but it's only up to you (it would be unfair to ask this
everytime a file is touched...).
--
Joel
prev parent reply other threads:[~2010-03-09 4:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 23:15 Kevin Buettner
2010-03-06 4:42 ` Joel Brobecker
2010-03-06 7:04 ` Kevin Buettner
2010-03-07 5:33 ` Joel Brobecker
2010-03-08 19:10 ` Kevin Buettner
2010-03-09 4:52 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309045227.GL3081@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox