Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: Verify AT_ENTRY before using it
Date: Mon, 08 Mar 2010 22:06:00 -0000	[thread overview]
Message-ID: <20100308220635.GC2629@caradoc.them.org> (raw)
In-Reply-To: <20100301200428.GA14079@host0.dyn.jankratochvil.net>

On Mon, Mar 01, 2010 at 09:04:28PM +0100, Jan Kratochvil wrote:
> The patch below combines (a)+(c)+(b) (in this order).  It also implements
> a warning on non-matching exec_bfd vs. target memory.  (d) is still left as
> applicable independent patch for approval.

Thanks for working on this.  I agree with all of it except the
warnings.  Since there's no other working way to accomplish (d)
today, and I have a use case for that which won't go away, I don't
think it's appropriate to warn.

Note, if the program headers matched but the alignment was not page
aligned, that would be a different case: that seems worth warning
about.  I don't know what that would mean.  Is it a case you've
encountered?

Without the warnings, this is OK to check in.  If you want the
warnings, we should discuss it a little more.

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2010-03-08 22:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24 22:49 Daniel Jacobowitz
2010-02-25 22:16 ` Jan Kratochvil
2010-02-26 21:12   ` Daniel Jacobowitz
2010-03-01 20:04     ` Jan Kratochvil
2010-03-01 21:22       ` [patch-testcase] " Jan Kratochvil
2010-03-08 22:13         ` Daniel Jacobowitz
2010-03-11 21:54           ` Jan Kratochvil
2010-03-11 21:57             ` Daniel Jacobowitz
2010-03-11 22:07               ` Jan Kratochvil
2010-03-08 22:06       ` Daniel Jacobowitz [this message]
2010-03-10 21:11         ` Jan Kratochvil
2010-03-10 21:55           ` Daniel Jacobowitz
2010-03-12 15:28           ` Jan Kratochvil
2010-03-12 15:39             ` Daniel Jacobowitz
2010-03-14  9:00               ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100308220635.GC2629@caradoc.them.org \
    --to=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox